Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 900633002: Add missing locale parameter to promo service. (Closed)

Created:
5 years, 10 months ago by droger
Modified:
5 years, 10 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add missing locale parameter to promo service. The locale parameter (hl=) has been broken by the componentization of web_resource, and is now always empty. This CL restores the right behavior. BUG=454485 Committed: https://crrev.com/df20b77a99b3542d7b5fe56ad7f7d9b3a88b2f33 Cr-Commit-Position: refs/heads/master@{#314334}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M components/web_resource/web_resource_service.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
droger
5 years, 10 months ago (2015-02-03 14:01:04 UTC) #3
Robert Sesek
LGTM. Thanks for the quick fix!
5 years, 10 months ago (2015-02-03 15:01:39 UTC) #4
Robert Sesek
LGTM. Thanks for the quick fix!
5 years, 10 months ago (2015-02-03 15:01:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/900633002/20001
5 years, 10 months ago (2015-02-03 15:02:39 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 10 months ago (2015-02-03 15:06:13 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 15:07:32 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/df20b77a99b3542d7b5fe56ad7f7d9b3a88b2f33
Cr-Commit-Position: refs/heads/master@{#314334}

Powered by Google App Engine
This is Rietveld 408576698