extensions: focus options overlay content when shown.

chrome/browser/resources/extensions/extension_list.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 <include src="extension_error.js">
 
 /**
  * The type of the extension data object. The definition is based on
  * chrome/browser/ui/webui/extensions/extension_basic_info.cc
  * and
@@ skipping 549 matching lines @@
       // Get the extension from the given id.
       var extension = this.data_.extensions.filter(function(extension) {
         return extension.enabled && extension.id == extensionId;
       })[0];
 
       if (!extension)
         return;
 
       if (scroll)
         this.scrollToNode_(extensionId);
+
+      document.activeElement.blur();
+
       // Add the options query string. Corner case: the 'options' query string
       // will clobber the 'id' query string if the options link is clicked when
       // 'id' is in the URL, or if both query strings are in the URL.
       uber.replaceState({}, '?options=' + extensionId);
 
-      extensions.ExtensionOptionsOverlay.getInstance().
-          setExtensionAndShowOverlay(extensionId,
-                                     extension.name,
-                                     extension.icon);
+      var shownCallback = function() {
+        if (cr.ui.FocusOutlineManager.forDocument(document).visible)
+          overlay.setInitialFocus();
+      };
 
+      var overlay = extensions.ExtensionOptionsOverlay.getInstance();
+      overlay.setExtensionAndShowOverlay(extensionId, extension.name,
+                                         extension.icon, shownCallback);
       this.optionsShown_ = true;
-      $('overlay').addEventListener('cancelOverlay', function() {
-        this.optionsShown_ = false;
-      }.bind(this));
+
+      var self = this;
+      $('overlay').addEventListener('cancelOverlay', function f() {
+        // Restore initial focus once this page isn't rebuild crazy.
+        // http://crbug.com/450818
+        self.optionsShown_ = false;
+        $('overlay').removeEventListener('cancelOverlay', f);
+      });
+
+      // TODO(dbeam): guestview's focus is weird. Only when this is called from
+      // within this event handler *and* after the showing animation completes
+      // does this work.
+      shownCallback();

[Dan Beam, 2015/02/04 18:11:21]

kalman@: ok with this?

     },
   };
 
   return {
     ExtensionsList: ExtensionsList
   };
 });