extensions: focus options overlay content when shown.

extensions: focus options overlay content when shown.

This matches other webui dialogs' (settings) behavior by setting initial
focus when a dialog is shown.

To fully match we need to also restore focus when the dialog is closed,
which we'll do when it's easier (i.e. when the page isn't totally
rebuilt all the time).

BUG=438301
R=kalman@chromium.org

Committed: https://crrev.com/161a7236f84ad703669a532b78f9b7dc17e0df58
Cr-Commit-Position: refs/heads/master@{#314629}

[Dan Beam, 2015-02-03 17:36:27]

Patchset #1 (id:1) has been deleted

[Dan Beam, 2015-02-03 17:38:47]

https://codereview.chromium.org/900623003/diff/20001/chrome/browser/resources...
File chrome/browser/resources/extensions/extension_list.js (right):

https://codereview.chromium.org/900623003/diff/20001/chrome/browser/resources...
chrome/browser/resources/extensions/extension_list.js:586: var self = this;
this is better than .bind() in this case (IMO) as when you .bind() you can't
removeEventListener() as easily

[not at google - send to devlin, 2015-02-03 20:52:04]

lgtm with the animation event --> callback change.

https://codereview.chromium.org/900623003/diff/40001/chrome/browser/resources...
File chrome/browser/resources/extensions/extension_list.js (right):

https://codereview.chromium.org/900623003/diff/40001/chrome/browser/resources...
chrome/browser/resources/extensions/extension_list.js:588:
$('overlay').addEventListener('animationFinished', function f() {
Consider commenting that the animation is started in
extension_options_overlay.js.

Though, even better, make setExtensionAndShowOverlay take a callback to run when
it's finished, then put this logic in that.

https://codereview.chromium.org/900623003/diff/40001/chrome/browser/resources...
File chrome/browser/resources/extensions/extension_options_overlay.js (right):

https://codereview.chromium.org/900623003/diff/40001/chrome/browser/resources...
chrome/browser/resources/extensions/extension_options_overlay.js:48:
getExentionOptions_: function() {
Exention -> Extension

kudos on being consistent, though.

[Dan Beam, 2015-02-03 21:03:33]

New patchsets have been uploaded after l-g-t-m from kalman@chromium.org

[Dan Beam, 2015-02-04 17:14:46]

Patchset #3 (id:60001) has been deleted

[Dan Beam, 2015-02-04 17:15:39]

https://codereview.chromium.org/900623003/diff/40001/chrome/browser/resources...
File chrome/browser/resources/extensions/extension_list.js (right):

https://codereview.chromium.org/900623003/diff/40001/chrome/browser/resources...
chrome/browser/resources/extensions/extension_list.js:588:
$('overlay').addEventListener('animationFinished', function f() {
On 2015/02/03 20:52:04, kalman wrote:
> Consider commenting that the animation is started in
> extension_options_overlay.js.
> 
> Though, even better, make setExtensionAndShowOverlay take a callback to run
when
> it's finished, then put this logic in that.

Done.

https://codereview.chromium.org/900623003/diff/40001/chrome/browser/resources...
File chrome/browser/resources/extensions/extension_options_overlay.js (right):

https://codereview.chromium.org/900623003/diff/40001/chrome/browser/resources...
chrome/browser/resources/extensions/extension_options_overlay.js:48:
getExentionOptions_: function() {
On 2015/02/03 20:52:04, kalman wrote:
> Exention -> Extension
> 
> kudos on being consistent, though.

Done. (ah, the magic of Ctrl+n)

[Dan Beam, 2015-02-04 18:11:21]

https://codereview.chromium.org/900623003/diff/80001/chrome/browser/resources...
File chrome/browser/resources/extensions/extension_list.js (right):

https://codereview.chromium.org/900623003/diff/80001/chrome/browser/resources...
chrome/browser/resources/extensions/extension_list.js:599: shownCallback();
kalman@: ok with this?

[not at google - send to devlin, 2015-02-04 20:33:09]

lgtm

[Dan Beam, 2015-02-04 20:55:08]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2015-02-04 20:56:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/900623003/100001

[commit-bot: I haz the power, 2015-02-04 21:01:06]

Committed patchset #4 (id:100001)

[commit-bot: I haz the power, 2015-02-04 21:03:00]

Patchset 4 (id:??) landed as
https://crrev.com/161a7236f84ad703669a532b78f9b7dc17e0df58
Cr-Commit-Position: refs/heads/master@{#314629}