chrome/browser/ui/cocoa/tabs/tab_strip_view.h - Issue 900613003: Mac: Make it easier for views to correctly draw with a theme.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/tabs/tab_strip_view.h

Issue 900613003: Mac: Make it easier for views to correctly draw with a theme. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gyp

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/cocoa/browser_window_controller.mm ('K') | « chrome/browser/ui/cocoa/floating_bar_backing_view.mm ('k') | chrome/browser/ui/cocoa/tabs/tab_strip_view.mm » ('j') | chrome/browser/ui/cocoa/tabs/tab_strip_view.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/tabs/tab_strip_view.h

diff --git a/chrome/browser/ui/cocoa/tabs/tab_strip_view.h b/chrome/browser/ui/cocoa/tabs/tab_strip_view.h

index c9196711c24396da57c4853b2c7b4d6a13ee29fd..931ad3fef60c52a5848b70b28cf98ea932e08f16 100644

--- a/chrome/browser/ui/cocoa/tabs/tab_strip_view.h

+++ b/chrome/browser/ui/cocoa/tabs/tab_strip_view.h

@@ -8,7 +8,7 @@

#import <Cocoa/Cocoa.h>

#include "base/mac/scoped_nsobject.h"

-#import "chrome/browser/ui/cocoa/background_gradient_view.h"

+#import "chrome/browser/ui/cocoa/themed_window.h"

#import "chrome/browser/ui/cocoa/url_drop_target.h"

@class NewTabButton;

@@ -17,7 +17,7 @@

// A view class that handles rendering the tab strip and drops of URLS with

// a positioning locator for drop feedback.

-@interface TabStripView : BackgroundGradientView<URLDropTarget> {

+@interface TabStripView : NSView<ThemedWindowDrawing, URLDropTarget> {

Andre 2015/02/03 19:13:19 See https://codereview.chromium.org/867273003/ for

@private

TabStripController* controller_; // Weak; owns us.