Mac: Make it easier for views to correctly draw with a theme.

chrome/browser/ui/cocoa/tabs/tab_strip_view.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/tabs/tab_strip_view.h"
 
 #include <cmath>  // floor
 
 #include "base/logging.h"
 #include "chrome/browser/themes/theme_service.h"
@@ skipping 46 matching lines @@
   CGFloat backgroundHeight = 2 * [self cr_lineWidth];
   if (NSMinY(dirtyRect) < backgroundHeight) {
     gfx::ScopedNSGraphicsContextSaveGState scopedGState;
     NSGraphicsContext *context = [NSGraphicsContext currentContext];
     NSPoint position = [[self window] themeImagePositionForAlignment:
         THEME_IMAGE_ALIGN_WITH_TAB_STRIP];
     [context cr_setPatternPhase:position forView:self];
 
     // Themes don't have an inactive image so only look for one if there's no
     // theme.
-    bool active = [[self window] isKeyWindow] || [[self window] isMainWindow] ||
-                  !themeProvider->UsingDefaultTheme();
+    bool active =
+        [[self window] isMainWindow] || !themeProvider->UsingDefaultTheme();

[Andre, 2015/02/03 19:20:37]

I discussed this with Robert yesterday.
The browser window is never key but not main, only child windows can be.

     int resource_id = active ? IDR_THEME_TOOLBAR : IDR_THEME_TOOLBAR_INACTIVE;
     [themeProvider->GetNSImageColorNamed(resource_id) set];
     NSRectFill(
         NSMakeRect(NSMinX(dirtyRect), 0, NSWidth(dirtyRect), backgroundHeight));
   }
 
   // Draw the border bitmap, which is partially transparent.
   NSImage* image = themeProvider->GetNSImageNamed(IDR_TOOLBAR_SHADE_TOP);
   if (NSMinY(dirtyRect) >= [image size].height)
     return;
 
   NSRect borderRect = dirtyRect;
   borderRect.size.height = [image size].height;
   borderRect.origin.y = 0;
 
-  BOOL focused = [[self window] isKeyWindow] || [[self window] isMainWindow];
+  BOOL focused = [[self window] isMainWindow];
   NSDrawThreePartImage(borderRect, nil, image, nil, /*vertical=*/ NO,
                        NSCompositeSourceOver,
                        focused ?  1.0 : tabs::kImageNoFocusAlpha,
                        /*flipped=*/ NO);
 }
 
 - (void)drawRect:(NSRect)rect {
   NSRect boundsRect = [self bounds];
 
   [self drawBorder:boundsRect];
@@ skipping 194 matching lines @@
 }
 
 - (void)setNewTabButton:(NewTabButton*)button {
   newTabButton_.reset([button retain]);
 }
 
 - (void)setController:(TabStripController*)controller {
   controller_ = controller;
 }
 
+// ThemedWindowDrawing implementation.
+
+- (void)windowDidChangeTheme {
+  [self setNeedsDisplay:YES];
+}
+
+- (void)windowDidChangeActive {
+  [self setNeedsDisplay:YES];
+}
+
 @end