Rip Out the Sidebar API

chrome/common/extensions/manifest_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/extensions/manifest.h"
 
 #include <algorithm>
 #include <set>
 #include <string>
 
@@ skipping 31 matching lines @@
   keys::kBackgroundPageLegacy,
   keys::kOfflineEnabled,
   keys::kMinimumChromeVersion,
   keys::kRequirements,
   keys::kConvertedFromUserScript,
   keys::kNaClModules,
   keys::kPlugins,
   keys::kContentScripts,
   keys::kOmnibox,
   keys::kDevToolsPage,
-  keys::kSidebar,
   keys::kHomepageURL,
   keys::kContentSecurityPolicy,
   keys::kFileBrowserHandlers,
   keys::kIncognito,
   keys::kInputComponents,
   keys::kTtsEngine,
   keys::kIntents,
   keys::kWebAccessibleResources
 };
 
 // Keys that are not accessible by hosted apps.
 const char* kNotHostedAppKeys[] = {
   keys::kBrowserAction,
   keys::kPageAction,
   keys::kPageActions,
   keys::kChromeURLOverrides,
   keys::kContentScripts,
   keys::kOmnibox,
   keys::kDevToolsPage,
-  keys::kSidebar,
   keys::kHomepageURL,
   keys::kContentSecurityPolicy,
   keys::kFileBrowserHandlers,
   keys::kIncognito,
   keys::kInputComponents,
   keys::kTtsEngine,
   keys::kIntents
 };
 
 // Keys not accessible by packaged aps.
 const char* kNotPackagedAppKeys[] = {
   keys::kBrowserAction,
   keys::kPageAction,
   keys::kPageActions
 };
 
 // Keys not accessible by platform apps.
 const char* kNotPlatformAppKeys[] = {
   keys::kBrowserAction,
   keys::kPageAction,
   keys::kPageActions,
   keys::kChromeURLOverrides,
   keys::kContentScripts,
   keys::kOmnibox,
   keys::kDevToolsPage,
-  keys::kSidebar,
   keys::kHomepageURL,
   keys::kPlugins,
   keys::kInputComponents,
   keys::kTtsEngine,
   keys::kFileBrowserHandlers
 };
 
 // Returns all the manifest keys not including those in |filtered| or kTypeKeys.
 std::set<std::string> GetAccessibleKeys(const char* filtered[], size_t length) {
   std::set<std::string> all_keys = Manifest::GetAllKnownKeys();
@@ skipping 280 matching lines @@
   ListValue* expected_list = new ListValue();
   ListValue* actual_list = NULL;
   expected_list->Append(Value::CreateStringValue("blah"));
   value->Set(unknown_key, expected_list);
   EXPECT_FALSE(manifest->GetList(unknown_key, &actual_list));
   EXPECT_EQ(NULL, actual_list);
   EXPECT_TRUE(value->Remove(unknown_key, NULL));
 }
 
 }  // namespace extensions