Rip Out the Sidebar API

chrome/browser/ui/cocoa/browser_window_controller_unittest.mm

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/mac/mac_util.h"
 #include "base/memory/scoped_nsobject.h"
 #include "base/memory/scoped_ptr.h"
 #include "chrome/app/chrome_command_ids.h"
 #include "chrome/browser/prefs/pref_service.h"
 #include "chrome/browser/sync/sync_ui_util.h"
@@ skipping 35 matching lines @@
 }
 
 - (NSView*)findBarView {
   return [findBarCocoaController_ view];
 }
 
 - (NSSplitView*)devToolsView {
   return static_cast<NSSplitView*>([devToolsController_ view]);
 }
 
-- (NSView*)sidebarView {
-  return [sidebarController_ view];
-}
-
 - (BOOL)bookmarkBarVisible {
   return [bookmarkBarController_ isVisible];
 }
 @end
 
 class BrowserWindowControllerTest : public CocoaProfileTest {
  public:
   virtual void SetUp() {
     CocoaProfileTest::SetUp();
     ASSERT_TRUE(browser());
@@ skipping 532 matching lines @@
       [subviews indexOfObject:[controller_ toolbarView]];
   EXPECT_NE(NSNotFound, toolbar_index);
   NSUInteger bookmark_index =
       [subviews indexOfObject:[controller_ bookmarkView]];
   EXPECT_NE(NSNotFound, bookmark_index);
 
   EXPECT_GT(findBar_index, toolbar_index);
   EXPECT_GT(findBar_index, bookmark_index);
 }
 
-// Tests that the sidebar view and devtools view are both non-opaque.
-TEST_F(BrowserWindowControllerTest, TestSplitViewsAreNotOpaque) {
-  // Add a subview to the sidebar view to mimic what happens when a tab is added
-  // to the window.  NSSplitView only marks itself as non-opaque when one of its
-  // subviews is non-opaque, so the test will not pass without this subview.
-  scoped_nsobject<NSView> view(
-      [[NSView alloc] initWithFrame:NSMakeRect(0, 0, 10, 10)]);
-  [[controller_ sidebarView] addSubview:view];
-
-  EXPECT_FALSE([[controller_ tabContentArea] isOpaque]);
-  EXPECT_FALSE([[controller_ devToolsView] isOpaque]);
-  EXPECT_FALSE([[controller_ sidebarView] isOpaque]);
-}
-
 // Tests that status bubble's base frame does move when devTools are docked.
 TEST_F(BrowserWindowControllerTest, TestStatusBubblePositioning) {
   ASSERT_EQ(1U, [[[controller_ devToolsView] subviews] count]);
 
   NSPoint bubbleOrigin = [controller_ statusBubbleBaseFrame].origin;
 
   // Add a fake subview to devToolsView to emulate docked devTools.
   scoped_nsobject<NSView> view(
       [[NSView alloc] initWithFrame:NSMakeRect(0, 0, 10, 10)]);
   [[controller_ devToolsView] addSubview:view];
@@ skipping 94 matching lines @@
   testFullscreenWindow_.reset(
       [[NSWindow alloc] initWithContentRect:NSMakeRect(0,0,400,400)
                                   styleMask:NSBorderlessWindowMask
                                     backing:NSBackingStoreBuffered
                                       defer:NO]);
   return testFullscreenWindow_.get();
 }
 @end
 
 /* TODO(???): test other methods of BrowserWindowController */