Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Issue 900583003: Reland of: Only store leading 13 bits of password hash. (Closed)

Created:
5 years, 10 months ago by Mike Lerman
Modified:
5 years, 10 months ago
Reviewers:
bcwhite, jww, Mike Lerman, jwd, sky
CC:
chromium-reviews, tfarina, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of: Only store leading 13 bits of password hash. Reland of: 862103002 at patchset 120001 Reverted here: https://codereview.chromium.org/875983008/ BUG=454553, 433180 R=jww@chromium.org, bcwhite@chromium.org, jwd@chromium.org, sky@chromium.org TBR=mlerman@chromium.org Committed: https://crrev.com/6fd469ad55039c45056bbe119b8dac8e4f0a8514 Cr-Commit-Position: refs/heads/master@{#314559}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+236 lines, -78 lines) Patch
M chrome/browser/signin/chrome_signin_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/signin/local_auth.h View 1 chunk +29 lines, -11 lines 0 comments Download
M chrome/browser/signin/local_auth.cc View 7 chunks +127 lines, -49 lines 0 comments Download
M chrome/browser/signin/local_auth_unittest.cc View 4 chunks +65 lines, -8 lines 0 comments Download
M chrome/browser/signin/signin_manager_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/profiles/profile_chooser_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/signin/inline_login_handler_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/signin/user_manager_screen_handler.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/900583003/1
5 years, 10 months ago (2015-02-04 15:06:31 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-04 15:10:02 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 15:11:33 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6fd469ad55039c45056bbe119b8dac8e4f0a8514
Cr-Commit-Position: refs/heads/master@{#314559}

Powered by Google App Engine
This is Rietveld 408576698