chrome/browser/chromeos/login/existing_user_controller.cc - Issue 900553006: Updated KioskAppManager to track whether an app was auto-launched.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/existing_user_controller.cc

Issue 900553006: Updated KioskAppManager to track whether an app was auto-launched. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed review comments. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/login/app_launch_controller.h ('K') | « chrome/browser/chromeos/login/app_launch_controller.cc ('k') | chrome/browser/chromeos/login/kiosk_browsertest.cc » ('j') | chrome/browser/chromeos/login/ui/login_display_host_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/existing_user_controller.cc

diff --git a/chrome/browser/chromeos/login/existing_user_controller.cc b/chrome/browser/chromeos/login/existing_user_controller.cc

index 70f0d5a73680ae5dc71a8bda0db27c6c662b519e..f416234b4f49764553e701db219d9c588eb9bdbb 100644

--- a/chrome/browser/chromeos/login/existing_user_controller.cc

+++ b/chrome/browser/chromeos/login/existing_user_controller.cc

@@ -923,7 +923,7 @@ void ExistingUserController::LoginAsPublicSession(

void ExistingUserController::LoginAsKioskApp(const std::string& app_id,

bool diagnostic_mode) {

- host_->StartAppLaunch(app_id, diagnostic_mode);

+ host_->StartAppLaunch(app_id, diagnostic_mode, false /* auto_start */);

Dmitry Polukhin 2015/02/06 13:41:32 Nit, I think better to create names local variable

Andrew T Wilson (Slow) 2015/02/06 20:43:50 Done.

}

void ExistingUserController::ConfigurePublicSessionAutoLogin() {