Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(689)

Unified Diff: chrome/browser/chromeos/app_mode/kiosk_app_manager.cc

Issue 900553006: Updated KioskAppManager to track whether an app was auto-launched. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed review comments. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/app_mode/kiosk_app_manager.cc
diff --git a/chrome/browser/chromeos/app_mode/kiosk_app_manager.cc b/chrome/browser/chromeos/app_mode/kiosk_app_manager.cc
index 86affa2eb9a99c32f645f77589b9fa93f1a44c5b..516dc7bea2699a5525b493e6722256995ef9f888 100644
--- a/chrome/browser/chromeos/app_mode/kiosk_app_manager.cc
+++ b/chrome/browser/chromeos/app_mode/kiosk_app_manager.cc
@@ -100,15 +100,19 @@ void KioskAppManager::RegisterPrefs(PrefRegistrySimple* registry) {
registry->RegisterDictionaryPref(kKioskDictionaryName);
}
-KioskAppManager::App::App(const KioskAppData& data, bool is_extension_pending)
+KioskAppManager::App::App(
+ const KioskAppData& data, bool is_extension_pending,
bartfab (slow) 2015/02/06 14:14:07 Nit: The style guide says: "For function declarat
Andrew T Wilson (Slow) 2015/02/06 20:43:49 Done.
+ bool auto_launched_with_zero_delay)
: app_id(data.app_id()),
user_id(data.user_id()),
name(data.name()),
icon(data.icon()),
- is_loading(data.IsLoading() || is_extension_pending) {
+ is_loading(data.IsLoading() || is_extension_pending),
+ was_auto_launched_with_zero_delay(auto_launched_with_zero_delay) {
}
-KioskAppManager::App::App() : is_loading(false) {}
+KioskAppManager::App::App() : is_loading(false),
+ was_auto_launched_with_zero_delay(false) {}
KioskAppManager::App::~App() {}
bartfab (slow) 2015/02/06 14:14:07 Nit: Add a blank line above.
Andrew T Wilson (Slow) 2015/02/06 20:43:49 Done.
std::string KioskAppManager::GetAutoLaunchApp() const {
@@ -131,6 +135,12 @@ void KioskAppManager::SetAutoLaunchApp(const std::string& app_id) {
kAccountsPrefDeviceLocalAccountAutoLoginDelay, 0);
}
+void KioskAppManager::SetAppWasAutoLaunchedWithZeroDelay(
+ const std::string& app_id) {
+ DCHECK_EQ(auto_launch_app_id_, app_id);
+ currently_auto_launched_app_ = app_id;
+}
+
void KioskAppManager::EnableConsumerKioskAutoLaunch(
const KioskAppManager::EnableKioskAutoLaunchCallback& callback) {
policy::BrowserPolicyConnectorChromeOS* connector =
@@ -311,9 +321,11 @@ void KioskAppManager::GetApps(Apps* apps) const {
apps->reserve(apps_.size());
for (size_t i = 0; i < apps_.size(); ++i) {
const KioskAppData& app_data = *apps_[i];
- if (app_data.status() != KioskAppData::STATUS_ERROR)
+ if (app_data.status() != KioskAppData::STATUS_ERROR) {
apps->push_back(App(
- app_data, external_cache_->IsExtensionPending(app_data.app_id())));
+ app_data, external_cache_->IsExtensionPending(app_data.app_id()),
+ app_data.app_id() == currently_auto_launched_app_));
+ }
}
}
@@ -322,7 +334,8 @@ bool KioskAppManager::GetApp(const std::string& app_id, App* app) const {
if (!data)
return false;
- *app = App(*data, external_cache_->IsExtensionPending(app_id));
+ *app = App(*data, external_cache_->IsExtensionPending(app_id),
+ app_id == currently_auto_launched_app_);
return true;
}

Powered by Google App Engine
This is Rietveld 408576698