Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 900553005: Skip direct map from apk check for all Samsung. (Closed)

Created:
5 years, 10 months ago by simonb (inactive)
Modified:
5 years, 10 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Skip direct map from apk check for all Samsung. If the device manufacturer is Samsung, skip the check for mmap exec support. This avoids triggering a warning on some devices. See also: https://codereview.chromium.org/869593002/ https://codereview.chromium.org/858983002/ https://codereview.chromium.org/857833002/ BUG=448084 Committed: https://crrev.com/b1969b94183f4f4b1e2e6ccbf8221061d2d3e687 Cr-Commit-Position: refs/heads/master@{#314362}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M base/android/java/src/org/chromium/base/library_loader/LibraryLoader.java View 1 chunk +1 line, -7 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
simonb (inactive)
5 years, 10 months ago (2015-02-03 15:01:28 UTC) #2
simonb (inactive)
5 years, 10 months ago (2015-02-03 16:39:48 UTC) #4
picksi
for what it's worth... lgtm
5 years, 10 months ago (2015-02-03 16:42:20 UTC) #5
rmcilroy
lgtm.
5 years, 10 months ago (2015-02-03 17:08:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/900553005/1
5 years, 10 months ago (2015-02-03 17:12:14 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-03 17:49:34 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 17:51:00 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b1969b94183f4f4b1e2e6ccbf8221061d2d3e687
Cr-Commit-Position: refs/heads/master@{#314362}

Powered by Google App Engine
This is Rietveld 408576698