Issue 900553003: Reset inlining limits due to overly long compilation times in Speedometer, Dart2JS

Issue 900553003: Reset inlining limits due to overly long compilation times in Speedometer, Dart2JS (Closed)

Created:
5 years, 10 months ago by Toon Verwaest

Modified:
5 years, 10 months ago

Reviewers:
mvstanton

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Reset inlining limits due to overly long compilation times in Speedometer, Dart2JS BUG=454625 LOG=y Committed: https://crrev.com/fea7ddb64069114d82c20951dd6948612e64ae7f Cr-Commit-Position: refs/heads/master@{#26405}

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -4 lines)			Patch
	M	src/flag-definitions.h	View		1 chunk	+3 lines, -3 lines	0 comments	Download
	M	src/hydrogen.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download

Total messages: 11 (4 generated)

Toon Verwaest

PTAL I additionally added always inlining of small methods, which slightly mitigates the performance loss ...

5 years, 10 months ago (2015-02-03 10:42:16 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/900553003/1

5 years, 10 months ago (2015-02-03 11:36:05 UTC) #5

commit-bot: I haz the power

Try jobs failed on following builders: v8_presubmit on tryserver.v8 (http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/321)

5 years, 10 months ago (2015-02-03 11:38:28 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/900553003/1

5 years, 10 months ago (2015-02-03 15:01:25 UTC) #9

commit-bot: I haz the power

5 years, 10 months ago (2015-02-03 15:03:08 UTC) #11

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/fea7ddb64069114d82c20951dd6948612e64ae7f
Cr-Commit-Position: refs/heads/master@{#26405}