gpu/command_buffer/service/shader_translator.cc - Issue 900543004: Clean up some of the shader compilation code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/shader_translator.cc

Issue 900543004: Clean up some of the shader compilation code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added shader length unit test and fixed length check Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gpu/command_buffer/service/shader_translator.cc

diff --git a/gpu/command_buffer/service/shader_translator.cc b/gpu/command_buffer/service/shader_translator.cc

index 878490c3cb9d7e15da3f0f81b2960dbe78a13492..98d738d74fd1bb19364c58eaa721533c54dd67db 100644

--- a/gpu/command_buffer/service/shader_translator.cc

+++ b/gpu/command_buffer/service/shader_translator.cc

@@ -123,7 +123,6 @@ bool ShaderTranslator::Init(

compiler_ = ShConstructCompiler(

shader_type, shader_spec, shader_output, resources);

}

- compiler_options_ = *resources;

implementation_is_glsl_es_ = (glsl_implementation_type == kGlslES);

driver_bug_workarounds_ = driver_bug_workarounds;

return compiler_ != NULL;