Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 900533003: IDL: Support [Unforgeable] on interface definitions (Closed)

Created:
5 years, 10 months ago by Jens Widell
Modified:
5 years, 10 months ago
Reviewers:
haraken, bashi
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

IDL: Support [Unforgeable] on interface definitions An interface having [Unforgeable] should have the same effect as if every non-static attribute or method had [Unforgeable]. BUG=444015 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189411

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -21 lines) Patch
M Source/bindings/scripts/v8_attributes.py View 6 chunks +8 lines, -8 lines 0 comments Download
M Source/bindings/scripts/v8_methods.py View 6 chunks +9 lines, -7 lines 0 comments Download
M Source/bindings/scripts/v8_utilities.py View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/bindings/tests/idls/core/TestInterfaceWillBeGarbageCollected.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceWillBeGarbageCollected.cpp View 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Jens Widell
PTAL This does not change code generation. No current interface definition has [Unforgeable], but the ...
5 years, 10 months ago (2015-02-03 12:12:48 UTC) #2
haraken
LGTM
5 years, 10 months ago (2015-02-03 12:14:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/900533003/1
5 years, 10 months ago (2015-02-03 12:16:11 UTC) #5
bashi
LGTM
5 years, 10 months ago (2015-02-03 12:23:26 UTC) #6
philipj_slow
Thanks!
5 years, 10 months ago (2015-02-03 13:23:05 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 13:34:02 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189411

Powered by Google App Engine
This is Rietveld 408576698