Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Unified Diff: remoting/host/register_support_host_request_unittest.cc

Issue 9005034: Refactor SignalStrategy so that it can be reused for multiple connections. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: - Created 8 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/host/register_support_host_request.cc ('k') | remoting/jingle_glue/fake_signal_strategy.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/host/register_support_host_request_unittest.cc
diff --git a/remoting/host/register_support_host_request_unittest.cc b/remoting/host/register_support_host_request_unittest.cc
index c5b626124f9e9cae531b7ff9ba34e8d0d7c85b57..dc3258d492f2bc699204d20a380c39a74a47e331 100644
--- a/remoting/host/register_support_host_request_unittest.cc
+++ b/remoting/host/register_support_host_request_unittest.cc
@@ -76,10 +76,12 @@ TEST_F(RegisterSupportHostRequestTest, Send) {
XmlElement* sent_iq = NULL;
EXPECT_CALL(signal_strategy_, GetNextId())
.WillOnce(Return(kStanzaId));
+ EXPECT_CALL(signal_strategy_, GetLocalJid())
+ .WillRepeatedly(Return(kTestJid));
EXPECT_CALL(signal_strategy_, SendStanza(NotNull()))
.WillOnce(DoAll(SaveArg<0>(&sent_iq), Return(true)));
- request->OnSignallingConnected(&signal_strategy_, kTestJid);
+ request->OnSignallingConnected(&signal_strategy_);
message_loop_.RunAllPending();
// Verify format of the query.
@@ -134,7 +136,7 @@ TEST_F(RegisterSupportHostRequestTest, Send) {
support_id_lifetime->AddText(kSupportIdLifetime);
result->AddElement(support_id_lifetime);
- EXPECT_TRUE(listener->OnIncomingStanza(response.get()));
+ EXPECT_TRUE(listener->OnSignalStrategyIncomingStanza(response.get()));
message_loop_.RunAllPending();
EXPECT_CALL(signal_strategy_, RemoveListener(listener));
« no previous file with comments | « remoting/host/register_support_host_request.cc ('k') | remoting/jingle_glue/fake_signal_strategy.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698