Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2726)

Unified Diff: extensions/browser/api/printer_provider_internal/printer_provider_internal_api.cc

Issue 900503002: List printers managed by extensions in print preview (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/printer_provider_internal/printer_provider_internal_api.cc
diff --git a/extensions/browser/api/printer_provider_internal/printer_provider_internal_api.cc b/extensions/browser/api/printer_provider_internal/printer_provider_internal_api.cc
index a5bd9eb6216e6fb655a594f2abf1c7adadabccef..e8879659d2a49b1fd64737c70868739221991123 100644
--- a/extensions/browser/api/printer_provider_internal/printer_provider_internal_api.cc
+++ b/extensions/browser/api/printer_provider_internal/printer_provider_internal_api.cc
@@ -47,7 +47,7 @@ void PrinterProviderInternalAPI::RemoveObserver(
void PrinterProviderInternalAPI::NotifyGetPrintersResult(
const Extension* extension,
int request_id,
- const base::ListValue& printers) {
+ const PrinterProviderInternalAPIObserver::PrinterInfoVector& printers) {
FOR_EACH_OBSERVER(PrinterProviderInternalAPIObserver, observers_,
OnGetPrintersResult(extension, request_id, printers));
}
@@ -132,17 +132,17 @@ PrinterProviderInternalReportPrintersFunction::Run() {
base::ListValue printers;
if (params->printers) {
- for (size_t i = 0; i < params->printers->size(); ++i) {
- scoped_ptr<base::DictionaryValue> printer(
- params->printers->at(i)->ToValue());
- printer->SetString("extensionId", extension()->id());
- printers.Append(printer.release());
- }
+ PrinterProviderInternalAPI::GetFactoryInstance()
+ ->Get(browser_context())
+ ->NotifyGetPrintersResult(extension(), params->request_id,
+ *params->printers);
+ } else {
+ PrinterProviderInternalAPI::GetFactoryInstance()
+ ->Get(browser_context())
+ ->NotifyGetPrintersResult(
+ extension(), params->request_id,
+ PrinterProviderInternalAPIObserver::PrinterInfoVector());
}
-
- PrinterProviderInternalAPI::GetFactoryInstance()
- ->Get(browser_context())
- ->NotifyGetPrintersResult(extension(), params->request_id, printers);
return RespondNow(NoArguments());
}

Powered by Google App Engine
This is Rietveld 408576698