Add another batch of GenerateTraits.

Add another batch of GenerateTraits.

BUG=450268
R=inferno@chromium.org,tsepez@chromium.org

Committed: https://crrev.com/b4bc73284daa05b7492cf46a0be2d12989ad1f8c
Cr-Commit-Position: refs/heads/master@{#314717}

[Tom Sepez, 2015-02-02 23:58:53]

https://codereview.chromium.org/900483002/diff/1/tools/ipc_fuzzer/mutate/gene...
File tools/ipc_fuzzer/mutate/generate.cc (right):

https://codereview.chromium.org/900483002/diff/1/tools/ipc_fuzzer/mutate/gene...
tools/ipc_fuzzer/mutate/generate.cc:453: template <class A, class B, class C,
class D>
This may be implementation-dependent, eg. the __1 isn't sure to be portable. 
Can't we just do it for the 4-parameter map case?

https://codereview.chromium.org/900483002/diff/1/tools/ipc_fuzzer/mutate/gene...
tools/ipc_fuzzer/mutate/generate.cc:524: return false;
nice catch.

[Martin Barbella, 2015-02-03 00:04:08]

https://codereview.chromium.org/900483002/diff/1/tools/ipc_fuzzer/mutate/gene...
File tools/ipc_fuzzer/mutate/generate.cc (right):

https://codereview.chromium.org/900483002/diff/1/tools/ipc_fuzzer/mutate/gene...
tools/ipc_fuzzer/mutate/generate.cc:453: template <class A, class B, class C,
class D>
On 2015/02/02 23:58:53, Tom Sepez wrote:
> This may be implementation-dependent, eg. the __1 isn't sure to be portable. 
> Can't we just do it for the 4-parameter map case?

Done.

[inferno, 2015-02-03 04:26:49]

lgtm. 

please double check all the param traits to make sure we are not missing any
more vars. we have a lot of missing param traits, so lets keep adding these.

Please reverse code change in
https://code.google.com/p/chromium/issues/detail?id=169770 and make sure our
fuzzing hits this (the one i was talking today). If not, why not, please analyze
in detail. These sorts of easy vulns should be instantly catchable.

https://codereview.chromium.org/900483002/diff/20001/tools/ipc_fuzzer/mutate/...
File tools/ipc_fuzzer/mutate/generate.cc (right):

https://codereview.chromium.org/900483002/diff/20001/tools/ipc_fuzzer/mutate/...
tools/ipc_fuzzer/mutate/generate.cc:996: case 0: {
use real enums here.

https://codereview.chromium.org/900483002/diff/20001/tools/ipc_fuzzer/mutate/...
tools/ipc_fuzzer/mutate/generate.cc:1013: if (!GenerateParam(&params->anchor,
generator))
missing scale_factor

https://codereview.chromium.org/900483002/diff/20001/tools/ipc_fuzzer/mutate/...
tools/ipc_fuzzer/mutate/generate.cc:1040: blink::WebCursorInfo::Type type;
missing some vars

   gfx::Point hotspot;
    float image_scale_factor;
    SkBitmap custom_image;
#if defined(OS_WIN)
    HCURSOR external_handle;

https://codereview.chromium.org/900483002/diff/20001/tools/ipc_fuzzer/mutate/...
tools/ipc_fuzzer/mutate/generate.cc:1051: // This can crash if arbitrary strings
are passed to it, so intentially
Add a TODO here.

https://codereview.chromium.org/900483002/diff/20001/tools/ipc_fuzzer/mutate/...
tools/ipc_fuzzer/mutate/generate.cc:1662: char bytes[256];
Add a FIXME: since kLargeThresholdBytes is the max size allowed.
https://code.google.com/p/chromium/codesearch#chromium/src/content/child/webb...

https://codereview.chromium.org/900483002/diff/20001/tools/ipc_fuzzer/mutate/...
tools/ipc_fuzzer/mutate/generate.cc:1697: case 4: {
please use enum here, a little more clear - WebBlobData::Item::TypeFileSystemURL

https://codereview.chromium.org/900483002/diff/20001/tools/ipc_fuzzer/mutate/...
tools/ipc_fuzzer/mutate/generate.cc:1767: int valid_schemes;
This is missing a bunch of other vars, like port, host, etc.

[Tom Sepez, 2015-02-04 01:38:24]

LGTM

[Martin Barbella, 2015-02-04 22:28:25]

New patchsets have been uploaded after l-g-t-m from tsepez@chromium.org

[Martin Barbella, 2015-02-04 22:31:23]

Just noticed that I missed a comment. Another patch set coming soon, so no point
in checking this one.

https://codereview.chromium.org/900483002/diff/20001/tools/ipc_fuzzer/mutate/...
File tools/ipc_fuzzer/mutate/generate.cc (right):

https://codereview.chromium.org/900483002/diff/20001/tools/ipc_fuzzer/mutate/...
tools/ipc_fuzzer/mutate/generate.cc:1662: char bytes[256];
On 2015/02/03 04:26:48, inferno wrote:
> Add a FIXME: since kLargeThresholdBytes is the max size allowed.
>
https://code.google.com/p/chromium/codesearch#chromium/src/content/child/webb...

It seems like this isn't the case for storage::DataElement, but that allocating
more than kLargeThresholdBytes can lead down a different code path later. We
should try to handle this at some point.

[Martin Barbella, 2015-02-04 22:42:14]

PTAL

[Tom Sepez, 2015-02-05 01:23:15]

lgtm

[Martin Barbella, 2015-02-05 01:39:37]

The CQ bit was checked by mbarbella@chromium.org

[commit-bot: I haz the power, 2015-02-05 01:40:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/900483002/60001

[commit-bot: I haz the power, 2015-02-05 02:01:01]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-02-05 02:02:29]

Patchset 4 (id:??) landed as
https://crrev.com/b4bc73284daa05b7492cf46a0be2d12989ad1f8c
Cr-Commit-Position: refs/heads/master@{#314717}