Issue 900473007: Add incognito:split for gaia_auth manifest used in Hotrod case

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 900473007: Add incognito:split for gaia_auth manifest used in Hotrod case (Closed)

Created:
5 years, 10 months ago by Dmitry Polukhin

Modified:
5 years, 10 months ago

Reviewers:
Nikita (slow)

CC:
chromium-reviews, arv+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Add incognito:split for gaia_auth manifest used in Hotrod case GAIA auth extension use special manifest file for Hotrod Enrollment case. This manifest also needs incognito:split to work on login screen. BUG=453448 TEST=manual Committed: https://crrev.com/f91e62e42ede9160e10b5c39f6090fced55ded31 Cr-Commit-Position: refs/heads/master@{#314539}

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	chrome/browser/resources/gaia_auth/manifest_keyboard.json	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/900473007/1

5 years, 10 months ago (2015-02-04 10:36:49 UTC) #5

commit-bot: I haz the power

5 years, 10 months ago (2015-02-04 11:22:26 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/f91e62e42ede9160e10b5c39f6090fced55ded31
Cr-Commit-Position: refs/heads/master@{#314539}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages