Source/core/paint/SVGShapePainter.cpp - Issue 900463002: Make SVG painting independent of GraphicsContext's alpha state

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/paint/SVGShapePainter.cpp

Issue 900463002: Make SVG painting independent of GraphicsContext's alpha state (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/paint/SVGRootInlineBoxPainter.cpp ('k') | Source/core/rendering/svg/RenderSVGResourcePaintServer.h » ('j') | Source/core/rendering/svg/RenderSVGResourcePaintServer.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/paint/SVGShapePainter.cpp

diff --git a/Source/core/paint/SVGShapePainter.cpp b/Source/core/paint/SVGShapePainter.cpp

index 706d5972c726b50e2b972856eea22f4b124da282..0a3cffba6504f9e952537415418ecd61b9d11f62 100644

--- a/Source/core/paint/SVGShapePainter.cpp

+++ b/Source/core/paint/SVGShapePainter.cpp

@@ -55,10 +55,6 @@ void SVGShapePainter::paint(const PaintInfo& paintInfo)

PaintInfo paintInfoBeforeFiltering(paintInfo);

FloatRect boundingBox = m_renderSVGShape.paintInvalidationRectInLocalCoordinates();

- // FIXME: Remove this state saver when SVGRenderSupport::updateGraphicsContext

- // no longer affects the global alpha state. See crbug.com/453225

- GraphicsContextStateSaver stateSaver(*paintInfoBeforeFiltering.context);

TransformRecorder transformRecorder(*paintInfoBeforeFiltering.context, m_renderSVGShape.displayItemClient(), m_renderSVGShape.localTransform());

{

SVGRenderingContext renderingContext(m_renderSVGShape, paintInfoBeforeFiltering);