Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Issue 900433002: Merge the following changes to XFA branch: (Closed)

Created:
5 years, 10 months ago by jam
Modified:
5 years, 10 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@xfa
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Merge the following changes to XFA branch: b3a788e Fix GN PDFium build when building all. by John Abd-El-Malek - 19 hours ago chromium/2293 f8af677 Always use the FreeType headers included in PDFium. by John Abd-El-Malek - 24 hours ago dc8c950 Don't export any OpenJPEG methods from PDFium. by John Abd-El-Malek - 3 days ago 71c24b8 Use system FreeType on Linux. by John Abd-El-Malek - 3 days ago R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/ef4dce44bb4b990f301a98853075f501c6f053d7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -52 lines) Patch
M BUILD.gn View 3 chunks +14 lines, -5 lines 0 comments Download
M core/include/fxge/fx_freetype.h View 2 chunks +7 lines, -8 lines 0 comments Download
M core/src/fxcodec/fx_libopenjpeg/libopenjpeg20/openjpeg.h View 1 chunk +1 line, -23 lines 0 comments Download
M core/src/fxge/ge/fx_ge_text.cpp View 10 chunks +0 lines, -14 lines 0 comments Download
M pdfium.gyp View 3 chunks +19 lines, -2 lines 0 comments Download
M third_party/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
jam
5 years, 10 months ago (2015-02-02 23:35:48 UTC) #2
Tom Sepez
RS LGTM.
5 years, 10 months ago (2015-02-02 23:53:53 UTC) #3
jam
5 years, 10 months ago (2015-02-03 00:52:16 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ef4dce44bb4b990f301a98853075f501c6f053d7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698