Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 900423002: X87: new classes: change semantics of super(...) call and add new.target to construct stub. (Closed)

Created:
5 years, 10 months ago by chunyang.dai
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: new classes: change semantics of super(...) call and add new.target to construct stub. port 22ce08ade63a9c4f28225db11a5b5d2726c5a8e7 (r26227) original commit message: new classes: change semantics of super(...) call and add new.target to construct stub. BUG= R=weiliang.lin@intel.com Committed: https://chromium.googlesource.com/v8/v8/+/bd4476a6232c366cd9f7965009e3a520084abb8d

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -35 lines) Patch
M src/x87/builtins-x87.cc View 4 chunks +51 lines, -29 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/x87/full-codegen-x87.cc View 3 chunks +54 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
chunyang.dai
WL. PTAL. thanks
5 years, 10 months ago (2015-02-07 04:19:13 UTC) #3
Weiliang
lgtm
5 years, 10 months ago (2015-02-07 06:18:40 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/bd4476a6232c366cd9f7965009e3a520084abb8d Cr-Commit-Position: refs/heads/master@{#26500}
5 years, 10 months ago (2015-02-07 06:21:30 UTC) #5
chunyang.dai
5 years, 10 months ago (2015-02-07 06:21:36 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:20001) manually as
bd4476a6232c366cd9f7965009e3a520084abb8d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698