Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(742)

Unified Diff: pkg/analyzer2dart/lib/src/converted_world.dart

Issue 900403003: Support default constructors in analyzer2dart. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer2dart/lib/src/converted_world.dart
diff --git a/pkg/analyzer2dart/lib/src/converted_world.dart b/pkg/analyzer2dart/lib/src/converted_world.dart
index f54a7a6e3decdb0f14d12ceccf6d443ff5861500..600487a800fba8b5a832e8d51127a57709e79c11 100644
--- a/pkg/analyzer2dart/lib/src/converted_world.dart
+++ b/pkg/analyzer2dart/lib/src/converted_world.dart
@@ -31,6 +31,8 @@ class _ConvertedWorldImpl implements ConvertedWorld {
final dart2js.FunctionElement mainFunction;
Map<dart2js.AstElement, ir.Node> executableElements =
new HashMap<dart2js.AstElement, ir.Node>();
+ final List<dart2js.ClassElement> instantiatedClasses =
+ <dart2js.ClassElement>[];
_ConvertedWorldImpl(this.mainFunction);
@@ -40,8 +42,6 @@ class _ConvertedWorldImpl implements ConvertedWorld {
Iterable<dart2js.AstElement> get resolvedElements => executableElements.keys;
- Iterable<dart2js.ClassElement> get instantiatedClasses => [];
-
ir.Node getIr(dart2js.Element element) => executableElements[element];
final dart2js.DartTypes dartTypes = new _DartTypes();
@@ -61,9 +61,8 @@ ConvertedWorld convertWorld(ClosedWorld closedWorld) {
converter.convertElement(analyzerElement);
CpsElementVisitor visitor = new CpsElementVisitor(converter, node);
ir.Node cpsNode = analyzerElement.accept(visitor);
- if (cpsNode != null) {
- convertedWorld.executableElements[dart2jsElement] = cpsNode;
- } else {
+ convertedWorld.executableElements[dart2jsElement] = cpsNode;
+ if (cpsNode == null && !analyzerElement.isSynthetic) {
String message =
'No CPS node generated for $analyzerElement (${node.runtimeType}).';
reportSourceMessage(analyzerElement.source, node, message);
@@ -71,9 +70,18 @@ ConvertedWorld convertWorld(ClosedWorld closedWorld) {
}
}
+ void convertClass(analyzer.ClassElement analyzerElement, _) {
+ // Skip conversion of SDK sources since we don't generate code for it
+ // anyway.
+ if (analyzerElement.source.isInSystemLibrary) return;
+ convertedWorld.instantiatedClasses.add(
+ converter.convertElement(analyzerElement));
+ }
+
closedWorld.executableElements.forEach(convert);
closedWorld.variables.forEach(convert);
closedWorld.fields.forEach(convert);
+ closedWorld.instantiatedClasses.forEach(convertClass);
return convertedWorld;
}
« no previous file with comments | « no previous file | pkg/analyzer2dart/lib/src/cps_generator.dart » ('j') | pkg/analyzer2dart/lib/src/cps_generator.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698