Introduce a kSetEventMaskCommand, some cleanups in windows eventhandler

dart/runtime/bin/eventhandler_win.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "platform/globals.h"
 #if defined(TARGET_OS_WINDOWS)
 
 #include "bin/eventhandler.h"
 
 #include <winsock2.h>  // NOLINT
@@ skipping 996 matching lines @@
 
 void EventHandlerImplementation::HandleInterrupt(InterruptMessage* msg) {
   ASSERT(this != NULL);
   if (msg->id == kTimerId) {
     // Change of timeout request. Just set the new timeout and port as the
     // completion thread will use the new timeout value for its next wait.
     timeout_queue_.UpdateTimeout(msg->dart_port, msg->data);
   } else if (msg->id == kShutdownId) {
     shutdown_ = true;
   } else {
-    // No tokens to return on Windows.
-    if ((msg->data & (1 << kReturnTokenCommand)) != 0) return;
     Handle* handle = reinterpret_cast<Handle*>(msg->id);
     ASSERT(handle != NULL);
     if (handle->is_listen_socket()) {
       ListenSocket* listen_socket =
           reinterpret_cast<ListenSocket*>(handle);
       listen_socket->EnsureInitialized(this);
-      listen_socket->SetPortAndMask(msg->dart_port, msg->data);
 
       Handle::ScopedLock lock(listen_socket);
 
-      // If incoming connections are requested make sure to post already
-      // accepted connections.
-      if ((msg->data & (1 << kInEvent)) != 0) {
-        if (listen_socket->CanAccept()) {
-          int event_mask = (1 << kInEvent);
-          handle->set_mask(handle->mask() & ~event_mask);
-          DartUtils::PostInt32(handle->port(), event_mask);
+      if (IS_COMMAND(msg->data, kReturnTokenCommand)) {
+        // No tokens to return on Windows.
+      } else if (IS_COMMAND(msg->data, kSetEventMaskCommand)) {
+        // `events` can only have kInEvent/kOutEvent flags set.
+        intptr_t events = msg->data & EVENT_MASK;
+        ASSERT(0 == (events & ~(1 << kInEvent | 1 << kOutEvent)));
+
+        listen_socket->SetPortAndMask(msg->dart_port, msg->data);
+
+        // If incoming connections are requested make sure to post already
+        // accepted connections.
+        if ((events & (1 << kInEvent)) != 0) {
+          if (listen_socket->CanAccept()) {
+            int event_mask = (1 << kInEvent);
+            handle->set_mask(handle->mask() & ~event_mask);
+            DartUtils::PostInt32(handle->port(), event_mask);
+          }
         }
+      } else if (IS_COMMAND(msg->data, kCloseCommand)) {
+        handle->SetPortAndMask(msg->dart_port, msg->data);
+        handle->Close();
+      } else {
+        UNREACHABLE();
       }
     } else {
       handle->EnsureInitialized(this);
 
       Handle::ScopedLock lock(handle);
 
-      // Only set mask if we turned on kInEvent or kOutEvent.
-      if ((msg->data & ((1 << kInEvent) | (1 << kOutEvent))) != 0) {
+      if (IS_COMMAND(msg->data, kReturnTokenCommand)) {
+        // No tokens to return on Windows.
+      } else if (IS_COMMAND(msg->data, kSetEventMaskCommand)) {
+        // `events` can only have kInEvent/kOutEvent flags set.
+        intptr_t events = msg->data & EVENT_MASK;
+        ASSERT(0 == (events & ~(1 << kInEvent | 1 << kOutEvent)));
+
         handle->SetPortAndMask(msg->dart_port, msg->data);
-      }
 
-      // Issue a read.
-      if ((msg->data & (1 << kInEvent)) != 0) {
-        if (handle->is_datagram_socket()) {
-          handle->IssueRecvFrom();
-        } else if (handle->is_client_socket()) {
-          if (reinterpret_cast<ClientSocket*>(handle)->is_connected()) {
+        // Issue a read.
+        if ((msg->data & (1 << kInEvent)) != 0) {
+          if (handle->is_datagram_socket()) {
+            handle->IssueRecvFrom();
+          } else if (handle->is_client_socket()) {
+            if (reinterpret_cast<ClientSocket*>(handle)->is_connected()) {
+              handle->IssueRead();
+            }
+          } else {
             handle->IssueRead();
           }
-        } else {
-          handle->IssueRead();
         }
-      }
 
-      // If out events (can write events) have been requested, and there
-      // are no pending writes, meaning any writes are already complete,
-      // post an out event immediately.
-      if ((msg->data & (1 << kOutEvent)) != 0) {
-        if (!handle->HasPendingWrite()) {
-          if (handle->is_client_socket()) {
-            if (reinterpret_cast<ClientSocket*>(handle)->is_connected()) {
+        // If out events (can write events) have been requested, and there
+        // are no pending writes, meaning any writes are already complete,
+        // post an out event immediately.
+        if ((msg->data & (1 << kOutEvent)) != 0) {
+          if (!handle->HasPendingWrite()) {
+            if (handle->is_client_socket()) {
+              if (reinterpret_cast<ClientSocket*>(handle)->is_connected()) {
+                DartUtils::PostInt32(handle->port(), 1 << kOutEvent);
+              }
+            } else {
               DartUtils::PostInt32(handle->port(), 1 << kOutEvent);
             }
-          } else {
-            DartUtils::PostInt32(handle->port(), 1 << kOutEvent);
           }
         }
-      }
+      } else if (IS_COMMAND(msg->data, kShutdownReadCommand)) {
+        ASSERT(handle->is_client_socket());
 
-      if (handle->is_client_socket()) {
         ClientSocket* client_socket = reinterpret_cast<ClientSocket*>(handle);
         if ((msg->data & (1 << kShutdownReadCommand)) != 0) {
           client_socket->Shutdown(SD_RECEIVE);
         }
+      } else if (IS_COMMAND(msg->data, kShutdownWriteCommand)) {
+        ASSERT(handle->is_client_socket());
 
+        ClientSocket* client_socket = reinterpret_cast<ClientSocket*>(handle);
         if ((msg->data & (1 << kShutdownWriteCommand)) != 0) {
           client_socket->Shutdown(SD_SEND);
         }
+      } else if (IS_COMMAND(msg->data, kCloseCommand)) {
+        handle->SetPortAndMask(msg->dart_port, msg->data);
+        handle->Close();
+      } else {
+        UNREACHABLE();
       }
     }
 
-    if ((msg->data & (1 << kCloseCommand)) != 0) {
-      handle->SetPortAndMask(msg->dart_port, msg->data);
-      handle->Close();
-    }
-
     DeleteIfClosed(handle);
   }
 }
 
 
 void EventHandlerImplementation::HandleAccept(ListenSocket* listen_socket,
                                               OverlappedBuffer* buffer) {
   listen_socket->AcceptComplete(buffer, completion_port_);
 
   if (!listen_socket->IsClosing()) {
@@ skipping 257 matching lines @@
 
 
 void EventHandlerImplementation::Shutdown() {
   SendData(kShutdownId, 0, 0);
 }
 
 }  // namespace bin
 }  // namespace dart
 
 #endif  // defined(TARGET_OS_WINDOWS)