Issue 90033004: Have CSSAnimationData::name() / initialAnimationName() return an AtomicString

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 90033004: Have CSSAnimationData::name() / initialAnimationName() return an AtomicString (Closed)

Created:
7 years ago by Inactive

Modified:
7 years ago

Reviewers:
abarth-chromium

CC:
blink-reviews, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), dstockwell, Timothy Loh, darktears, Steve Block, dino_apple.com, Eric Willigers

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Have CSSAnimationData::name() / initialAnimationName() return an AtomicString Have CSSAnimationData::name() / initialAnimationName() return an AtomicString instead of a String. Most callers require an AtomicString and needed to convert the returned String to an AtomicString. Also note that m_name is stored as an AtomicString anyway and setName() already takes an AtomicString in argument. R=abarth BUG=323739 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162768

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	Source/core/platform/animation/CSSAnimationData.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
	M	Source/core/platform/animation/CSSAnimationData.cpp	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/90033004/1

7 years ago (2013-11-27 04:32:50 UTC) #3

commit-bot: I haz the power

Retried try job too often on linux_blink for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink&number=4086

7 years ago (2013-11-27 06:46:11 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/90033004/1

7 years ago (2013-11-27 14:07:27 UTC) #5

Message was sent while issue was closed.

Change committed as 162768

Expand Messages | Collapse Messages