minidump/minidump_memory_writer_test.cc - Issue 900323003: %zu to PRIuS in minidump

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: minidump/minidump_memory_writer_test.cc

Issue 900323003: %zu to PRIuS in minidump (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@land-crash-report-db-win

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: minidump/minidump_memory_writer_test.cc

diff --git a/minidump/minidump_memory_writer_test.cc b/minidump/minidump_memory_writer_test.cc

index 1aee35dee65247f85e08ab72874a9e6178107a35..e77a0648a95e3ae087703099124ea6487d45fb48 100644

--- a/minidump/minidump_memory_writer_test.cc

+++ b/minidump/minidump_memory_writer_test.cc

@@ -19,6 +19,7 @@

#include <stdint.h>

#include "base/basictypes.h"

+#include "base/format_macros.h"

#include "base/strings/stringprintf.h"

#include "gtest/gtest.h"

#include "minidump/minidump_extensions.h"

@@ -347,7 +348,7 @@ TEST(MinidumpMemoryWriter, AddFromSnapshot) {

ASSERT_EQ(3u, memory_list->NumberOfMemoryRanges);

for (size_t index = 0; index < memory_list->NumberOfMemoryRanges; ++index) {

- SCOPED_TRACE(base::StringPrintf("index %zu", index));

+ SCOPED_TRACE(base::StringPrintf("index %" PRIuS, index));

ExpectMinidumpMemoryDescriptorAndContents(

&expect_memory_descriptors[index],

&memory_list->MemoryRanges[index],