Issue 900323003: %zu to PRIuS in minidump

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 900323003: %zu to PRIuS in minidump (Closed)

Created:
5 years, 10 months ago by scottmg

Modified:
5 years, 10 months ago

Reviewers:
Mark Mentovai

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@land-crash-report-db-win

Target Ref:
refs/heads/master

Project:
crashpad

Visibility:
Public.

More Reviews

Description

%zu to PRIuS in minidump R=mark@chromium.org BUG=crashpad:1 Committed: https://chromium.googlesource.com/crashpad/crashpad/+/06b89552af271273c5d0ef7b2f64545f08c9943c

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -11 lines)			Patch
M	minidump/minidump_location_descriptor_list_writer_test.cc	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	minidump/minidump_memory_writer_test.cc	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	minidump/minidump_module_writer_test.cc	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	minidump/minidump_rva_list_writer_test.cc	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	minidump/minidump_string_writer_test.cc	View	4 chunks	+5 lines, -4 lines	0 comments	Download
M	minidump/minidump_thread_writer_test.cc	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	minidump/test/minidump_context_test_util.cc	View	3 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

LGTM. I really should have been doing this all along, I know better. Sorry.

5 years, 10 months ago (2015-02-05 22:30:45 UTC) #2

scottmg

Committed patchset #1 (id:1) manually as 06b89552af271273c5d0ef7b2f64545f08c9943c (presubmit successful).

5 years, 10 months ago (2015-02-05 23:04:54 UTC) #3

scottmg

5 years, 10 months ago (2015-02-05 23:04:58 UTC) #4

Message was sent while issue was closed.

On 2015/02/05 22:30:45, Mark Mentovai wrote:
> LGTM. I really should have been doing this all along, I know better. Sorry.

Shrug, easy to fix. I'd stick with %zu on POSIX-only files as easier to read, so
I think this qualifies as porting work because previously everything was
POSIX-only. :)

Expand Messages | Collapse Messages