[WebView] Add unique visual state request ids.

[WebView] Add unique visual state request ids.

Each flushVisualState request returns a unique id
that allows callers to match requests with callbacks.
The reasoning behind is to potentially allow clients
to reuse VisualStateFlushCallback objects to avoid
additional java allocations.

BUG=455651
Committed: https://crrev.com/d011b93e7c8f966ba068b0c77c8a1400bdedee88
Cr-Commit-Position: refs/heads/master@{#315304}

[Ignacio Solla, 2015-02-05 18:11:14]

igsolla@chromium.org changed reviewers:
+ boliu@chromium.org

[boliu, 2015-02-06 02:05:13]

Write a CL description pls.

code itself lgtm, although might be worthwhile to ask around if the actual api
design makes sense

https://codereview.chromium.org/900303002/diff/40001/android_webview/native/a...
File android_webview/native/aw_contents.cc (right):

https://codereview.chromium.org/900303002/diff/40001/android_webview/native/a...
android_webview/native/aw_contents.cc:1058: request_id));
uber-nit: clang-format this? somehow doesn't look right

[Ignacio Solla, 2015-02-09 11:30:17]

New patchsets have been uploaded after l-g-t-m from boliu@chromium.org

[Ignacio Solla, 2015-02-09 11:35:26]

I have updated the design doc, hopefully we will get feedback there once you
discuss it with API Council.

https://codereview.chromium.org/900303002/diff/40001/android_webview/native/a...
File android_webview/native/aw_contents.cc (right):

https://codereview.chromium.org/900303002/diff/40001/android_webview/native/a...
android_webview/native/aw_contents.cc:1058: request_id));
On 2015/02/06 02:05:13, boliu wrote:
> uber-nit: clang-format this? somehow doesn't look right

Done.

[Ignacio Solla, 2015-02-09 11:36:38]

The CQ bit was checked by igsolla@chromium.org

[commit-bot: I haz the power, 2015-02-09 11:37:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/900303002/60001

[commit-bot: I haz the power, 2015-02-09 13:38:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-09 13:38:46]

Try jobs failed on following builders:
  ios_dbg_simulator on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL)
  ios_rel_device_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL)
  ios_rel_device_ninja_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build
URL)
Timed out jobs are not retried to avoid causing additional load on the builders
with large pending queues.

[Ignacio Solla, 2015-02-09 15:36:26]

The CQ bit was checked by igsolla@chromium.org

[commit-bot: I haz the power, 2015-02-09 15:36:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/900303002/60001

[commit-bot: I haz the power, 2015-02-09 15:37:52]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-02-09 15:38:57]

Patchset 4 (id:??) landed as
https://crrev.com/d011b93e7c8f966ba068b0c77c8a1400bdedee88
Cr-Commit-Position: refs/heads/master@{#315304}

[Ignacio Solla, 2015-02-09 16:25:57]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/907723004/ by igsolla@chromium.org.

The reason for reverting is: This is breaking some bots, see for example:
https://chromegw.corp.google.com/i/chromium.linux/builders/Android%20Arm64%20...

https://chromegw.corp.google.com/i/chromium.linux/builders/Android%20Builder%...

The reason is:
M D ST: Write to static field
org.chromium.android_webview.AwContents.sNextVisualStateRequestId from instance
method
org.chromium.android_webview.AwContents.flushVisualState(AwContents$VisualStateFlushCallback)
 At AwContents.java

.