Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Issue 9003014: Replace WebUI::tab_contents() with web_contents() and switch all users to use web_contents.h inst... (Closed)

Created:
8 years, 12 months ago by jam
Modified:
8 years, 11 months ago
Reviewers:
Jói
CC:
chromium-reviews, asanka, vrk (LEFT CHROMIUM), jam, yusukes+watch_chromium.org, achuith+watch_chromium.org, yoshiki+watch_chromium.org, mihaip+watch_chromium.org, dcheng, ajwong+watch_chromium.org, nkostylev+watch_chromium.org, acolwell+watch_chromium.org, prasadt, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, annacc+watch_chromium.org, ihf+watch_chromium.org, jstritar+watch_chromium.org, Avi (use Gerrit), jennb, creis+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, Randy Smith (Not in Mondays), jianli, dpranke-watch+content_chromium.org, scherkus (not reviewing), hclam+watch_chromium.org, Dmitry Titov, Aaron Boodman, Paweł Hajdan Jr., estade+watch_chromium.org
Visibility:
Public.

Description

Replace WebUI::tab_contents() with web_contents() and switch all users to use web_contents.h instead of tab_contents.h. In a few cases some of these files used functions that needed a TabContents, so I switched them as well. BUG=98716 TBR=joi Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=116051

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Patch Set 8 : '' #

Patch Set 9 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+606 lines, -474 lines) Patch
M chrome/browser/chromeos/accessibility/accessibility_util.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/screen_locker_tester.cc View 1 2 3 4 5 6 7 8 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_install_ui.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_web_ui.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_web_ui.cc View 1 6 chunks +10 lines, -7 lines 0 comments Download
M chrome/browser/printing/cloud_print/cloud_print_setup_flow.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/printing/print_dialog_cloud.cc View 7 chunks +16 lines, -11 lines 0 comments Download
M chrome/browser/profiles/profile.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/tab_contents/background_contents.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/tab_contents/background_contents.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/task_manager/task_manager_browsertest.cc View 1 2 3 4 5 6 7 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/ui/browser.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_list.h View 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/ui/browser_list.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/browser_window.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/browser_window_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/browser_window_gtk.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/panels/panel.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/panels/panel.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/about_ui.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/about_ui.cc View 1 2 3 4 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/active_downloads_ui.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/active_downloads_ui.cc View 1 2 3 4 5 6 7 8 9 chunks +15 lines, -13 lines 0 comments Download
M chrome/browser/ui/webui/aura/app_list_ui.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/aura/app_list_ui.cc View 1 2 3 4 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/bookmarks_ui.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/bookmarks_ui.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/bug_report_ui.h View 1 2 3 4 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/ui/webui/bug_report_ui.cc View 1 2 3 4 5 6 8 chunks +11 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/certificate_viewer_ui.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/certificate_viewer_ui.cc View 1 2 3 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/certificate_viewer_webui.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/choose_mobile_network_ui.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/choose_mobile_network_ui.cc View 1 2 3 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/imageburner/imageburner_ui.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/imageburner/imageburner_ui.cc View 1 2 3 4 6 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/imageburner/imageburner_utils.h View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/imageburner/imageburner_utils.cc View 1 2 3 4 6 chunks +20 lines, -18 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/imageburner/webui_handler.h View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/enterprise_oauth_enrollment_screen_handler.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/oobe_ui.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/oobe_ui.cc View 1 2 3 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/mobile_setup_ui.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/mobile_setup_ui.cc View 1 2 3 4 5 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/proxy_settings_ui.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/proxy_settings_ui.cc View 1 2 3 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/register_page_ui.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/register_page_ui.cc View 1 2 3 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/sim_unlock_ui.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/sim_unlock_ui.cc View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/system_info_ui.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/system_info_ui.cc View 1 2 3 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/cloud_print_signin_dialog.h View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/cloud_print_signin_dialog.cc View 9 chunks +16 lines, -16 lines 0 comments Download
M chrome/browser/ui/webui/conflicts_ui.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/conflicts_ui.cc View 1 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/constrained_html_ui.h View 1 4 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/constrained_html_ui.cc View 1 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/crashes_ui.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/crashes_ui.cc View 1 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/devtools_ui.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/devtools_ui.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/downloads_dom_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/downloads_ui.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/downloads_ui.cc View 1 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/edit_search_engine_dialog_ui_webui.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/edit_search_engine_dialog_ui_webui.cc View 1 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extensions_ui.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/extensions/extensions_ui.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/flags_ui.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/flags_ui.cc View 1 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/flash_ui.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/flash_ui.cc View 1 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/gpu_internals_ui.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/gpu_internals_ui.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/history_ui.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/history_ui.cc View 1 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/html_dialog_ui.h View 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/html_dialog_ui.cc View 4 chunks +13 lines, -11 lines 0 comments Download
M chrome/browser/ui/webui/hung_renderer_dialog_ui.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/hung_renderer_dialog_ui.cc View 1 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/keyboard_ui.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/keyboard_ui.cc View 1 2 3 4 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/media/media_internals_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/media/media_internals_ui.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/media/media_internals_ui.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/metrics_handler.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/net_internals_ui.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/net_internals_ui.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/app_launcher_handler.cc View 1 2 3 4 5 6 7 3 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/new_tab_ui.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/new_tab_ui.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/ntp_login_handler.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/ntp/recently_closed_tabs_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/advanced_options_handler.cc View 7 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/ui/webui/options/advanced_options_utils.h View 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/options/advanced_options_utils_mac.mm View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/advanced_options_utils_win.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/options/advanced_options_utils_x11.cc View 6 chunks +13 lines, -12 lines 0 comments Download
M chrome/browser/ui/webui/options/certificate_manager_handler.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/cros_language_options_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/extension_settings_handler.cc View 5 chunks +8 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/options/options_ui.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/options_ui.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options/personal_options_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/advanced_options_handler2.cc View 7 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/ui/webui/options2/advanced_options_utils2.h View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/options2/advanced_options_utils2_mac.mm View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/advanced_options_utils2_win.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/options2/advanced_options_utils2_x11.cc View 1 2 3 6 chunks +13 lines, -12 lines 0 comments Download
M chrome/browser/ui/webui/options2/certificate_manager_handler2.cc View 7 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/change_picture_options_handler2.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/cros_language_options_handler2.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/options_ui2.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options2/options_ui2.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options2/personal_options_handler2.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/plugins_ui.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/plugins_ui.cc View 1 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/policy_ui.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/policy_ui.cc View 1 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/print_preview_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/print_preview_handler.cc View 8 chunks +14 lines, -12 lines 0 comments Download
M chrome/browser/ui/webui/print_preview_ui.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/print_preview_ui.cc View 1 6 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/profiler_ui.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/profiler_ui.cc View 1 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/quota_internals_ui.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/quota_internals_ui.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/sessions_ui.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/sessions_ui.cc View 1 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/sync_internals_ui.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/sync_internals_ui.cc View 1 3 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/sync_promo/sync_promo_handler.cc View 6 chunks +10 lines, -9 lines 0 comments Download
M chrome/browser/ui/webui/sync_promo/sync_promo_ui.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/sync_promo/sync_promo_ui.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/sync_setup_handler.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/sync_setup_handler2.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/task_manager_handler.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/task_manager_ui.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/task_manager_ui.cc View 1 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/test_chrome_web_ui_factory.h View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/ui/webui/test_chrome_web_ui_factory_browsertest.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/tracing_ui.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/tracing_ui.cc View 6 chunks +9 lines, -8 lines 0 comments Download
M chrome/browser/ui/webui/uber/uber_ui.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/uber/uber_ui.cc View 1 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/web_ui_browsertest.cc View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/web_ui_test_handler.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/workers_ui.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/workers_ui.cc View 1 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/common/chrome_notification_types.h View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/test/base/test_browser_window.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/test_html_dialog_observer.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/test/data/webui/certificate_viewer_ui_test-inl.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/webui/edit_search_engine_dialog_browsertest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/data/webui/hung_renderer_dialog_ui_test-inl.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/webui/generic_handler.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M content/browser/webui/web_ui.h View 5 chunks +8 lines, -5 lines 0 comments Download
M content/browser/webui/web_ui.cc View 4 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jam
8 years, 11 months ago (2011-12-30 19:06:50 UTC) #1
Jói
8 years, 11 months ago (2012-01-01 13:57:01 UTC) #2
LGTM

2011/12/30  <jam@chromium.org>:
> Reviewers: Jói,
>
> Description:
> Replace WebUI::tab_contents() with web_contents() and switch all users to
> use
> web_contents.h instead of tab_contents.h. In a few cases some of these files
> used functions that needed a TabContents, so I switched them as well.
>
> BUG=98716
> TBR=joi
>
> Please review this at http://codereview.chromium.org/9003014/
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     chrome/browser/chromeos/accessibility/accessibility_util.cc
>  M     chrome/browser/extensions/extension_install_ui.cc
>  M     chrome/browser/extensions/extension_web_ui.h
>  M     chrome/browser/extensions/extension_web_ui.cc
>  M     chrome/browser/printing/cloud_print/cloud_print_setup_flow.cc
>  M     chrome/browser/printing/print_dialog_cloud.cc
>  M     chrome/browser/profiles/profile.cc
>  M     chrome/browser/tab_contents/background_contents.h
>  M     chrome/browser/tab_contents/background_contents.cc
>  M     chrome/browser/tab_contents/render_view_context_menu.cc
>  M     chrome/browser/task_manager/task_manager_browsertest.cc
>  M     chrome/browser/ui/browser.h
>  M     chrome/browser/ui/browser.cc
>  M     chrome/browser/ui/browser_list.h
>  M     chrome/browser/ui/browser_list.cc
>  M     chrome/browser/ui/browser_window.h
>  M     chrome/browser/ui/cocoa/browser_window_cocoa.h
>  M     chrome/browser/ui/cocoa/browser_window_cocoa.mm
>  M     chrome/browser/ui/gtk/browser_window_gtk.h
>  M     chrome/browser/ui/gtk/browser_window_gtk.cc
>  M     chrome/browser/ui/panels/panel.h
>  M     chrome/browser/ui/panels/panel.cc
>  M     chrome/browser/ui/views/frame/browser_view.h
>  M     chrome/browser/ui/views/frame/browser_view.cc
>  M     chrome/browser/ui/webui/about_ui.h
>  M     chrome/browser/ui/webui/about_ui.cc
>  M     chrome/browser/ui/webui/active_downloads_ui.h
>  M     chrome/browser/ui/webui/active_downloads_ui.cc
>  chrome/browser/ui/webui/aura/app_list_ui.h
>  M     chrome/browser/ui/webui/aura/app_list_ui.cc
>  M     chrome/browser/ui/webui/bookmarks_ui.h
>  M     chrome/browser/ui/webui/bookmarks_ui.cc
>  M     chrome/browser/ui/webui/bug_report_ui.h
>  M     chrome/browser/ui/webui/bug_report_ui.cc
>  M     chrome/browser/ui/webui/certificate_viewer_ui.h
>  M     chrome/browser/ui/webui/certificate_viewer_ui.cc
>  M     chrome/browser/ui/webui/certificate_viewer_webui.cc
>  M     chrome/browser/ui/webui/chrome_web_ui.h
>  M     chrome/browser/ui/webui/chrome_web_ui.cc
>  M     chrome/browser/ui/webui/chromeos/choose_mobile_network_ui.h
>  M     chrome/browser/ui/webui/chromeos/choose_mobile_network_ui.cc
>  M     chrome/browser/ui/webui/chromeos/imageburner/imageburner_ui.h
>  M     chrome/browser/ui/webui/chromeos/imageburner/imageburner_ui.cc
>  M     chrome/browser/ui/webui/chromeos/imageburner/imageburner_utils.h
>  M     chrome/browser/ui/webui/chromeos/imageburner/imageburner_utils.cc
>  M     chrome/browser/ui/webui/chromeos/imageburner/webui_handler.h
>  M     chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.h
>  M     chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc
>  M
>
chrome/browser/ui/webui/chromeos/login/enterprise_oauth_enrollment_screen_handler.cc
>  M     chrome/browser/ui/webui/chromeos/login/oobe_ui.h
>  M     chrome/browser/ui/webui/chromeos/login/oobe_ui.cc
>  M     chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
>  M     chrome/browser/ui/webui/chromeos/mobile_setup_ui.h
>  M     chrome/browser/ui/webui/chromeos/mobile_setup_ui.cc
>  M     chrome/browser/ui/webui/chromeos/proxy_settings_ui.h
>  M     chrome/browser/ui/webui/chromeos/proxy_settings_ui.cc
>  M     chrome/browser/ui/webui/chromeos/register_page_ui.h
>  M     chrome/browser/ui/webui/chromeos/register_page_ui.cc
>  M     chrome/browser/ui/webui/chromeos/sim_unlock_ui.h
>  M     chrome/browser/ui/webui/chromeos/sim_unlock_ui.cc
>  M     chrome/browser/ui/webui/chromeos/system_info_ui.h
>  M     chrome/browser/ui/webui/chromeos/system_info_ui.cc
>  M     chrome/browser/ui/webui/cloud_print_signin_dialog.h
>  M     chrome/browser/ui/webui/cloud_print_signin_dialog.cc
>  M     chrome/browser/ui/webui/conflicts_ui.h
>  M     chrome/browser/ui/webui/conflicts_ui.cc
>  M     chrome/browser/ui/webui/constrained_html_ui.h
>  M     chrome/browser/ui/webui/constrained_html_ui.cc
>  M     chrome/browser/ui/webui/crashes_ui.h
>  M     chrome/browser/ui/webui/crashes_ui.cc
>  M     chrome/browser/ui/webui/devtools_ui.h
>  M     chrome/browser/ui/webui/devtools_ui.cc
>  M     chrome/browser/ui/webui/downloads_dom_handler.cc
>  M     chrome/browser/ui/webui/downloads_ui.h
>  M     chrome/browser/ui/webui/downloads_ui.cc
>  M     chrome/browser/ui/webui/edit_search_engine_dialog_ui_webui.h
>  M     chrome/browser/ui/webui/edit_search_engine_dialog_ui_webui.cc
>  M     chrome/browser/ui/webui/extensions/extensions_ui.h
>  M     chrome/browser/ui/webui/extensions/extensions_ui.cc
>  M     chrome/browser/ui/webui/flags_ui.h
>  M     chrome/browser/ui/webui/flags_ui.cc
>  M     chrome/browser/ui/webui/flash_ui.h
>  M     chrome/browser/ui/webui/flash_ui.cc
>  M     chrome/browser/ui/webui/gpu_internals_ui.h
>  M     chrome/browser/ui/webui/gpu_internals_ui.cc
>  M     chrome/browser/ui/webui/history_ui.h
>  M     chrome/browser/ui/webui/history_ui.cc
>  M     chrome/browser/ui/webui/html_dialog_ui.h
>  M     chrome/browser/ui/webui/html_dialog_ui.cc
>  M     chrome/browser/ui/webui/hung_renderer_dialog_ui.h
>  M     chrome/browser/ui/webui/hung_renderer_dialog_ui.cc
>  M     chrome/browser/ui/webui/keyboard_ui.h
>  M     chrome/browser/ui/webui/keyboard_ui.cc
>  M     chrome/browser/ui/webui/media/media_internals_handler.cc
>  M     chrome/browser/ui/webui/media/media_internals_ui.h
>  M     chrome/browser/ui/webui/media/media_internals_ui.cc
>  M     chrome/browser/ui/webui/metrics_handler.cc
>  M     chrome/browser/ui/webui/net_internals_ui.h
>  M     chrome/browser/ui/webui/net_internals_ui.cc
>  M     chrome/browser/ui/webui/ntp/app_launcher_handler.cc
>  M     chrome/browser/ui/webui/ntp/new_tab_ui.h
>  M     chrome/browser/ui/webui/ntp/new_tab_ui.cc
>  M     chrome/browser/ui/webui/ntp/ntp_login_handler.cc
>  M     chrome/browser/ui/webui/ntp/recently_closed_tabs_handler.cc
>  M     chrome/browser/ui/webui/options/advanced_options_handler.cc
>  M     chrome/browser/ui/webui/options/advanced_options_utils.h
>  M     chrome/browser/ui/webui/options/advanced_options_utils_mac.mm
>  M     chrome/browser/ui/webui/options/advanced_options_utils_win.cc
>  M     chrome/browser/ui/webui/options/advanced_options_utils_x11.cc
>  M     chrome/browser/ui/webui/options/certificate_manager_handler.cc
>  M
> chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.cc
>  M
> chrome/browser/ui/webui/options/chromeos/cros_language_options_handler.cc
>  M     chrome/browser/ui/webui/options/extension_settings_handler.cc
>  M     chrome/browser/ui/webui/options/options_ui.h
>  M     chrome/browser/ui/webui/options/options_ui.cc
>  M     chrome/browser/ui/webui/options/personal_options_handler.cc
>  M     chrome/browser/ui/webui/options2/advanced_options_handler2.cc
>  M     chrome/browser/ui/webui/options2/advanced_options_utils2.h
>  M     chrome/browser/ui/webui/options2/advanced_options_utils2_mac.mm
>  M     chrome/browser/ui/webui/options2/advanced_options_utils2_win.cc
>  M     chrome/browser/ui/webui/options2/advanced_options_utils2_x11.cc
>  M     chrome/browser/ui/webui/options2/certificate_manager_handler2.cc
>  M
> chrome/browser/ui/webui/options2/chromeos/change_picture_options_handler2.cc
>  M
> chrome/browser/ui/webui/options2/chromeos/cros_language_options_handler2.cc
>  M     chrome/browser/ui/webui/options2/options_ui2.h
>  M     chrome/browser/ui/webui/options2/options_ui2.cc
>  M     chrome/browser/ui/webui/options2/personal_options_handler2.cc
>  M     chrome/browser/ui/webui/plugins_ui.h
>  M     chrome/browser/ui/webui/plugins_ui.cc
>  M     chrome/browser/ui/webui/policy_ui.h
>  M     chrome/browser/ui/webui/policy_ui.cc
>  M     chrome/browser/ui/webui/print_preview_handler.h
>  M     chrome/browser/ui/webui/print_preview_handler.cc
>  M     chrome/browser/ui/webui/print_preview_ui.h
>  M     chrome/browser/ui/webui/print_preview_ui.cc
>  M     chrome/browser/ui/webui/profiler_ui.h
>  M     chrome/browser/ui/webui/profiler_ui.cc
>  M     chrome/browser/ui/webui/quota_internals_ui.h
>  M     chrome/browser/ui/webui/quota_internals_ui.cc
>  M     chrome/browser/ui/webui/sessions_ui.h
>  M     chrome/browser/ui/webui/sessions_ui.cc
>  M     chrome/browser/ui/webui/sync_internals_ui.h
>  M     chrome/browser/ui/webui/sync_internals_ui.cc
>  M     chrome/browser/ui/webui/sync_promo/sync_promo_handler.cc
>  M     chrome/browser/ui/webui/sync_promo/sync_promo_ui.h
>  M     chrome/browser/ui/webui/sync_promo/sync_promo_ui.cc
>  M     chrome/browser/ui/webui/sync_setup_handler.cc
>  M     chrome/browser/ui/webui/sync_setup_handler2.cc
>  M     chrome/browser/ui/webui/task_manager_handler.cc
>  M     chrome/browser/ui/webui/task_manager_ui.h
>  M     chrome/browser/ui/webui/task_manager_ui.cc
>  M     chrome/browser/ui/webui/test_chrome_web_ui_factory.h
>  M     chrome/browser/ui/webui/test_chrome_web_ui_factory_browsertest.cc
>  M     chrome/browser/ui/webui/tracing_ui.h
>  M     chrome/browser/ui/webui/tracing_ui.cc
>  M     chrome/browser/ui/webui/uber/uber_ui.h
>  M     chrome/browser/ui/webui/uber/uber_ui.cc
>  M     chrome/browser/ui/webui/web_ui_browsertest.cc
>  M     chrome/browser/ui/webui/web_ui_test_handler.cc
>  M     chrome/browser/ui/webui/workers_ui.h
>  M     chrome/browser/ui/webui/workers_ui.cc
>  M     chrome/common/chrome_notification_types.h
>  M     chrome/test/base/test_browser_window.h
>  M     chrome/test/base/test_html_dialog_observer.cc
>  M     chrome/test/data/webui/certificate_viewer_ui_test-inl.h
>  M     chrome/test/data/webui/edit_search_engine_dialog_browsertest.cc
>  M     chrome/test/data/webui/hung_renderer_dialog_ui_test-inl.h
>  M     content/browser/webui/generic_handler.cc
>  M     content/browser/webui/web_ui.h
>  M     content/browser/webui/web_ui.cc
>
>

Powered by Google App Engine
This is Rietveld 408576698