|
|
DescriptionRoll android_tools f6e2370:2a860d8
This rolls in an update to android_tools.gyp that provides targets for
Google Play Sevices libraries.
BUG=450675
Committed: https://crrev.com/f092ee226ac530125fb580485fc45765330f1a1d
Cr-Commit-Position: refs/heads/master@{#315037}
Patch Set 1 #Patch Set 2 : Update description #Messages
Total messages: 14 (4 generated)
aberent@chromium.org changed reviewers: + mcilroy@chromium.org
On 2015/02/05 17:51:32, aberent wrote: This is the CL; I had already added you as a reviewer, so I don't know why you didn't get the email
rmcilroy@chromium.org changed reviewers: + rmcilroy@chromium.org
Please update the title / first line of description to include the revisions being rolled from / too - i.e.: "Roll android_tools from f6e237 to 2a860d" Other than that, lgtm.
New patchsets have been uploaded after l-g-t-m from rmcilroy@chromium.org
The CQ bit was checked by aberent@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/900273003/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/f092ee226ac530125fb580485fc45765330f1a1d Cr-Commit-Position: refs/heads/master@{#315037}
Message was sent while issue was closed.
On 2015/02/06 15:30:46, I haz the power (commit-bot) wrote: > Patchset 2 (id:??) landed as > https://crrev.com/f092ee226ac530125fb580485fc45765330f1a1d > Cr-Commit-Position: refs/heads/master@{#315037} Hey, our builders (and me personally) are unable to build our Android builds after this: $ GYP_GENERATOR_FLAGS="out_android" build/gyp_chromium -DOS=android Updating projects from gyp files... find: `/usr/local/google/code/chromium/src/third_party/android_tools/sdk//extras/google/google_play_services/libproject/google-play-services_lib/res': No such file or directory gyp: Call to 'find /usr/local/google/code/chromium/src/third_party/android_tools/sdk//extras/google/google_play_services/libproject/google-play-services_lib/res -type f' returned exit status 1. $ GYP_GENERATOR_FLAGS="output_dir=out_cast_android" build/gyp_chromium -Dchromecast=1 -DOS=android && ninja -C out_cast_android/Debug cast_shell_apk cast_android_test_lists -k500 Updating projects from gyp files... find: `/usr/local/google/code/chromium/src/third_party/android_tools/sdk//extras/google/google_play_services/libproject/google-play-services_lib/res': No such file or directory gyp: Call to 'find /usr/local/google/code/chromium/src/third_party/android_tools/sdk//extras/google/google_play_services/libproject/google-play-services_lib/res -type f' returned exit status 1. $ ls -l third_party/android_tools/sdk//extras/google total 4.0K drwxr-x--- 5 gunsch eng 4.0K Aug 18 17:21 gcm/ So we seem to have the GYP targets depending on Google Play Services itself but not Google Play Services itself. gclient sync doesn't seem to pull it down. Thoughts?
Message was sent while issue was closed.
On 2015/02/06 at 17:05:39, gunsch wrote: > On 2015/02/06 15:30:46, I haz the power (commit-bot) wrote: > > Patchset 2 (id:??) landed as > > https://crrev.com/f092ee226ac530125fb580485fc45765330f1a1d > > Cr-Commit-Position: refs/heads/master@{#315037} > > Hey, our builders (and me personally) are unable to build our Android builds after this: > > $ GYP_GENERATOR_FLAGS="out_android" build/gyp_chromium -DOS=android > Updating projects from gyp files... > find: `/usr/local/google/code/chromium/src/third_party/android_tools/sdk//extras/google/google_play_services/libproject/google-play-services_lib/res': No such file or directory > gyp: Call to 'find /usr/local/google/code/chromium/src/third_party/android_tools/sdk//extras/google/google_play_services/libproject/google-play-services_lib/res -type f' returned exit status 1. > > $ GYP_GENERATOR_FLAGS="output_dir=out_cast_android" build/gyp_chromium -Dchromecast=1 -DOS=android && ninja -C out_cast_android/Debug cast_shell_apk cast_android_test_lists -k500 > Updating projects from gyp files... > find: `/usr/local/google/code/chromium/src/third_party/android_tools/sdk//extras/google/google_play_services/libproject/google-play-services_lib/res': No such file or directory > gyp: Call to 'find /usr/local/google/code/chromium/src/third_party/android_tools/sdk//extras/google/google_play_services/libproject/google-play-services_lib/res -type f' returned exit status 1. > > $ ls -l third_party/android_tools/sdk//extras/google > total 4.0K > drwxr-x--- 5 gunsch eng 4.0K Aug 18 17:21 gcm/ > > So we seem to have the GYP targets depending on Google Play Services itself but not Google Play Services itself. gclient sync doesn't seem to pull it down. Thoughts? Locally you need to run src/build/install-build-deps-android.sh (see my email sent yesterday). I wrongly thought this wouldn't be necessary until my next CL, which uses the Google Play Services landed. I am however distressed to hear that some of the builders are failing. I understood that Google Play Services had been installed on all the builders. Which builders are failing? I will, for now revert the CL until the builders are fixed.
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/889603009/ by aberent@chromium.org. The reason for reverting is: Some builders apparently don't yet have Google Play Services installed..
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/890633003/ by aberent@chromium.org. The reason for reverting is: Builders now updated. |