Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 900233002: Enumerate MJPEG as the prefered format if set. (Closed)

Created:
5 years, 10 months ago by perkj_chrome
Modified:
5 years, 10 months ago
Reviewers:
magjed_chromium
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enumerate MJPEG as the prefered format if set. This make sure that if it has been decided that MJPEG should be used in DirectShow after enumerating the device capabilities, the input pin enumerates MJPEG as the onle and only format. BUG=454869 Committed: https://crrev.com/9d2eae585146f128074c316dbf8d8a1d4da99f07 Cr-Commit-Position: refs/heads/master@{#314828}

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : Fixed nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -25 lines) Patch
M media/video/capture/win/sink_input_pin_win.cc View 1 2 2 chunks +18 lines, -9 lines 0 comments Download
M media/video/capture/win/video_capture_device_win.cc View 1 1 chunk +15 lines, -16 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
perkj_chrome
Can you please review?
5 years, 10 months ago (2015-02-05 12:42:57 UTC) #2
magjed_chromium
lgtm % nit https://codereview.chromium.org/900233002/diff/20001/media/video/capture/win/sink_input_pin_win.cc File media/video/capture/win/sink_input_pin_win.cc (right): https://codereview.chromium.org/900233002/diff/20001/media/video/capture/win/sink_input_pin_win.cc#newcode52 media/video/capture/win/sink_input_pin_win.cc:52: if (index == 0) { I ...
5 years, 10 months ago (2015-02-05 12:47:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/900233002/40001
5 years, 10 months ago (2015-02-05 16:22:34 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-05 17:19:26 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 17:20:30 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9d2eae585146f128074c316dbf8d8a1d4da99f07
Cr-Commit-Position: refs/heads/master@{#314828}

Powered by Google App Engine
This is Rietveld 408576698