Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 900223006: [ia32] Assembler support for internal references. (Closed)

Created:
5 years, 10 months ago by Benedikt Meurer
Modified:
5 years, 10 months ago
Reviewers:
dcarney
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ia32] Assembler support for internal references. BUG=v8:3872 LOG=n R=dcarney@chromium.org Committed: https://crrev.com/5c119485b485a5c71155501613ae3c12be2863a8 Cr-Commit-Position: refs/heads/master@{#26478}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -17 lines) Patch
M src/ia32/assembler-ia32.h View 7 chunks +17 lines, -5 lines 0 comments Download
M src/ia32/assembler-ia32.cc View 5 chunks +37 lines, -11 lines 0 comments Download
M src/ia32/disasm-ia32.cc View 2 chunks +3 lines, -1 line 0 comments Download
M test/cctest/test-assembler-ia32.cc View 1 chunk +96 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Benedikt Meurer
5 years, 10 months ago (2015-02-06 08:31:10 UTC) #1
dcarney
lgtm
5 years, 10 months ago (2015-02-06 08:33:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/900223006/1
5 years, 10 months ago (2015-02-06 08:40:24 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-06 08:51:46 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-06 08:52:03 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5c119485b485a5c71155501613ae3c12be2863a8
Cr-Commit-Position: refs/heads/master@{#26478}

Powered by Google App Engine
This is Rietveld 408576698