Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issue 900223004: [Mac, Win] The fast user switcher should use the small, non-high res default avatars (Closed)

Created:
5 years, 10 months ago by noms (inactive)
Modified:
5 years, 10 months ago
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac, Win] The fast user switcher should use the small, non-high res default avatars BUG=447311 TEST=Start Chrome with --enable-fast-user-switching. In the avatar bubble, any profiles with default avatar should display the low res, transparent background images (i.e. not the high res images with the grey background) Committed: https://crrev.com/9b3e2f24a690948518095b6859c25a1932a39c1a Cr-Commit-Position: refs/heads/master@{#315043}

Patch Set 1 #

Total comments: 2

Patch Set 2 : bad camelCase, bad #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
M chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm View 1 chunk +8 lines, -1 line 0 comments Download
M chrome/browser/ui/views/profiles/profile_chooser_view.cc View 1 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
noms (inactive)
This CL makes the avatars used in the avatar bubble's fast user switchers consistent with ...
5 years, 10 months ago (2015-02-05 21:25:33 UTC) #2
Alexei Svitkine (slow)
lgtm
5 years, 10 months ago (2015-02-05 21:27:45 UTC) #3
sky
LGTM https://codereview.chromium.org/900223004/diff/1/chrome/browser/ui/views/profiles/profile_chooser_view.cc File chrome/browser/ui/views/profiles/profile_chooser_view.cc (right): https://codereview.chromium.org/900223004/diff/1/chrome/browser/ui/views/profiles/profile_chooser_view.cc#newcode1253 chrome/browser/ui/views/profiles/profile_chooser_view.cc:1253: bool isRectangle; You've been writing too match mac ...
5 years, 10 months ago (2015-02-06 01:03:03 UTC) #4
noms (inactive)
https://codereview.chromium.org/900223004/diff/1/chrome/browser/ui/views/profiles/profile_chooser_view.cc File chrome/browser/ui/views/profiles/profile_chooser_view.cc (right): https://codereview.chromium.org/900223004/diff/1/chrome/browser/ui/views/profiles/profile_chooser_view.cc#newcode1253 chrome/browser/ui/views/profiles/profile_chooser_view.cc:1253: bool isRectangle; On 2015/02/06 01:03:02, sky wrote: > You've ...
5 years, 10 months ago (2015-02-06 15:53:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/900223004/20001
5 years, 10 months ago (2015-02-06 15:54:36 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-06 16:20:37 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-06 16:21:12 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9b3e2f24a690948518095b6859c25a1932a39c1a
Cr-Commit-Position: refs/heads/master@{#315043}

Powered by Google App Engine
This is Rietveld 408576698