Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 900223003: components: Provide an unified target to generate components_tests_resources.pak. (Closed)

Created:
5 years, 10 months ago by tfarina
Modified:
5 years, 10 months ago
Reviewers:
jam, blundell
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

components: Provide an unified target to generate components_tests_resources.pak. Instead of having separate actions for each test suite in components, provide a single target that can be used by both test targets. BUG=451827 R=blundell@chromium.org,jam@chromium.org TEST=components_unittests && components_browsertests Committed: https://crrev.com/4bb3f4788c97127aee4d05efed3cec261c43cfbd Cr-Commit-Position: refs/heads/master@{#315387}

Patch Set 1 #

Total comments: 4

Patch Set 2 : review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -39 lines) Patch
M components/components_browsertests.isolate View 1 chunk +1 line, -1 line 0 comments Download
M components/components_tests.gyp View 1 4 chunks +33 lines, -32 lines 0 comments Download
M components/components_unittests.isolate View 1 chunk +1 line, -1 line 0 comments Download
M components/dom_distiller/content/distiller_page_web_contents_browsertest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/dom_distiller/standalone/content_extractor.cc View 1 2 chunks +4 lines, -3 lines 0 comments Download
M components/test/run_all_unittests.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
tfarina
PTAL!
5 years, 10 months ago (2015-02-05 17:16:57 UTC) #1
jam
lgtm
5 years, 10 months ago (2015-02-05 21:24:57 UTC) #2
blundell
lgtm https://codereview.chromium.org/900223003/diff/1/components/dom_distiller/standalone/content_extractor.cc File components/dom_distiller/standalone/content_extractor.cc (right): https://codereview.chromium.org/900223003/diff/1/components/dom_distiller/standalone/content_extractor.cc#newcode1 components/dom_distiller/standalone/content_extractor.cc:1: // Copyright 2014 The Chromium Authors. All rights ...
5 years, 10 months ago (2015-02-06 08:25:31 UTC) #3
tfarina
https://codereview.chromium.org/900223003/diff/1/components/dom_distiller/standalone/content_extractor.cc File components/dom_distiller/standalone/content_extractor.cc (right): https://codereview.chromium.org/900223003/diff/1/components/dom_distiller/standalone/content_extractor.cc#newcode1 components/dom_distiller/standalone/content_extractor.cc:1: // Copyright 2014 The Chromium Authors. All rights reserved. ...
5 years, 10 months ago (2015-02-09 18:44:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/900223003/20001
5 years, 10 months ago (2015-02-09 18:44:41 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-09 21:00:13 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 21:00:42 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4bb3f4788c97127aee4d05efed3cec261c43cfbd
Cr-Commit-Position: refs/heads/master@{#315387}

Powered by Google App Engine
This is Rietveld 408576698