Issue 900203003: Clean up of plumbing HostID in declarative content API.

Issue 900203003: Clean up of plumbing HostID in declarative content API. (Closed)

Created:
5 years, 10 months ago by Xi Han

Modified:
5 years, 10 months ago

Reviewers:
Devlin

CC:
chromium-reviews, darin-cc_chromium.org, jam, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Clean up of plumbing HostID in declarative content API. BUG=437566 Committed: https://crrev.com/a4909ad305bc19e4c88fe142dce5aab0f2740b39 Cr-Commit-Position: refs/heads/master@{#315296}

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+37 lines, -91 lines)			Patch
M	chrome/browser/extensions/api/declarative_content/chrome_content_rules_registry.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/api/declarative_content/content_action.h	View	3 chunks	+0 lines, -8 lines	0 comments	Download
M	chrome/browser/extensions/api/declarative_content/content_action.cc	View	12 chunks	+3 lines, -12 lines	0 comments	Download
M	chrome/browser/extensions/api/declarative_content/content_action_unittest.cc	View	14 chunks	+3 lines, -15 lines	0 comments	Download
M	chrome/browser/extensions/api/declarative_webrequest/webrequest_action_unittest.cc	View	5 chunks	+8 lines, -15 lines	0 comments	Download
M	chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	extensions/browser/api/declarative/declarative_rule.h	View	7 chunks	+3 lines, -9 lines	0 comments	Download
M	extensions/browser/api/declarative/declarative_rule_unittest.cc	View	7 chunks	+17 lines, -24 lines	0 comments	Download
M	extensions/browser/api/declarative_webrequest/webrequest_action.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	extensions/browser/api/declarative_webrequest/webrequest_action.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	extensions/browser/api/declarative_webrequest/webrequest_rules_registry.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download

Total messages: 7 (2 generated)

Xi Han

Hi Devlin: please take a look this clean up patch. Thanks!

5 years, 10 months ago (2015-02-06 20:26:30 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/900203003/1

5 years, 10 months ago (2015-02-09 14:32:29 UTC) #5

commit-bot: I haz the power

5 years, 10 months ago (2015-02-09 14:36:16 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/a4909ad305bc19e4c88fe142dce5aab0f2740b39
Cr-Commit-Position: refs/heads/master@{#315296}