Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/code-stubs.cc

Issue 900193002: Remove the obsolete OverwriteMode optimization. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Address comments. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/code-stubs.h ('k') | src/code-stubs-hydrogen.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/code-stubs.h" 5 #include "src/code-stubs.h"
6 6
7 #include <sstream> 7 #include <sstream>
8 8
9 #include "src/bootstrapper.h" 9 #include "src/bootstrapper.h"
10 #include "src/cpu-profiler.h" 10 #include "src/cpu-profiler.h"
(...skipping 250 matching lines...) Expand 10 before | Expand all | Expand 10 after
261 void** value_out = reinterpret_cast<void**>(&code); 261 void** value_out = reinterpret_cast<void**>(&code);
262 Dispatch(isolate, key, value_out, &GetCodeDispatchCall); 262 Dispatch(isolate, key, value_out, &GetCodeDispatchCall);
263 return scope.CloseAndEscape(code); 263 return scope.CloseAndEscape(code);
264 } 264 }
265 265
266 266
267 // static 267 // static
268 void BinaryOpICStub::GenerateAheadOfTime(Isolate* isolate) { 268 void BinaryOpICStub::GenerateAheadOfTime(Isolate* isolate) {
269 // Generate the uninitialized versions of the stub. 269 // Generate the uninitialized versions of the stub.
270 for (int op = Token::BIT_OR; op <= Token::MOD; ++op) { 270 for (int op = Token::BIT_OR; op <= Token::MOD; ++op) {
271 for (int mode = NO_OVERWRITE; mode <= OVERWRITE_RIGHT; ++mode) { 271 BinaryOpICStub stub(isolate, static_cast<Token::Value>(op));
272 BinaryOpICStub stub(isolate, 272 stub.GetCode();
273 static_cast<Token::Value>(op),
274 static_cast<OverwriteMode>(mode));
275 stub.GetCode();
276 }
277 } 273 }
278 274
279 // Generate special versions of the stub. 275 // Generate special versions of the stub.
280 BinaryOpICState::GenerateAheadOfTime(isolate, &GenerateAheadOfTime); 276 BinaryOpICState::GenerateAheadOfTime(isolate, &GenerateAheadOfTime);
281 } 277 }
282 278
283 279
284 void BinaryOpICStub::PrintState(std::ostream& os) const { // NOLINT 280 void BinaryOpICStub::PrintState(std::ostream& os) const { // NOLINT
285 os << state(); 281 os << state();
286 } 282 }
(...skipping 690 matching lines...) Expand 10 before | Expand all | Expand 10 after
977 } 973 }
978 974
979 975
980 InternalArrayConstructorStub::InternalArrayConstructorStub( 976 InternalArrayConstructorStub::InternalArrayConstructorStub(
981 Isolate* isolate) : PlatformCodeStub(isolate) { 977 Isolate* isolate) : PlatformCodeStub(isolate) {
982 InternalArrayConstructorStubBase::GenerateStubsAheadOfTime(isolate); 978 InternalArrayConstructorStubBase::GenerateStubsAheadOfTime(isolate);
983 } 979 }
984 980
985 981
986 } } // namespace v8::internal 982 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/code-stubs.h ('k') | src/code-stubs-hydrogen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698