Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 900183004: Update {virtual,override,final} to follow C++11 style in chrome. (Closed)

Created:
5 years, 10 months ago by dcheng
Modified:
5 years, 10 months ago
Reviewers:
Nico
CC:
chromium-reviews, noyau+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update {virtual,override,final} to follow C++11 style in chrome. The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was automatically generated with an OS=android build using a variation of https://codereview.chromium.org/598073004. BUG=417463 Committed: https://crrev.com/12590ce9e74571df716b9f2db9ee18999820d7b7 Cr-Commit-Position: refs/heads/master@{#314953}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M chrome/android/shell/chrome_main_delegate_chrome_shell_android.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/sync_shell/chrome_main_delegate_chrome_sync_shell_android.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/app/android/chrome_main_delegate_android.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/app/chrome_crash_reporter_client.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/enhanced_bookmarks/android/bookmark_image_service_factory.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
dcheng
5 years, 10 months ago (2015-02-06 01:04:34 UTC) #2
Nico
lgtm
5 years, 10 months ago (2015-02-06 01:07:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/900183004/1
5 years, 10 months ago (2015-02-06 01:11:54 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-06 03:34:29 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-06 03:35:37 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/12590ce9e74571df716b9f2db9ee18999820d7b7
Cr-Commit-Position: refs/heads/master@{#314953}

Powered by Google App Engine
This is Rietveld 408576698