Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 900123003: Add NativeWeakMap to v8.h (Closed)

Created:
5 years, 10 months ago by yurys
Modified:
5 years, 10 months ago
CC:
v8-dev, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add NativeWeakMap to v8.h A new map wich references its keys weakly is added to v8.h. Internally it uses the same storage as JSWeakMap but doesn't depend on the JavaScript part of WeakMap implementation in weak-collection.js, hence it can be instantiated without entering any context. BUG=chromium:437416 LOG=Y Committed: https://crrev.com/a559367956d870de38375a51e919a2c06c004e26 Cr-Commit-Position: refs/heads/master@{#26451}

Patch Set 1 #

Patch Set 2 : Applied r26428 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+258 lines, -61 lines) Patch
M include/v8.h View 1 chunk +15 lines, -0 lines 0 comments Download
M src/api.h View 3 chunks +5 lines, -1 line 0 comments Download
M src/api.cc View 1 chunk +95 lines, -0 lines 0 comments Download
M src/factory.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/factory.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +7 lines, -0 lines 0 comments Download
M src/runtime/runtime-collections.cc View 6 chunks +37 lines, -21 lines 0 comments Download
M test/cctest/test-api.cc View 2 chunks +72 lines, -0 lines 0 comments Download
M test/cctest/test-weakmaps.cc View 1 6 chunks +9 lines, -21 lines 0 comments Download
M test/cctest/test-weaksets.cc View 1 5 chunks +7 lines, -18 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
yurys
This patch is a reworked version of r26425. It was modified in accord with dcarney's ...
5 years, 10 months ago (2015-02-05 08:32:41 UTC) #2
dcarney
lgtm wrt to v8.h and api.*
5 years, 10 months ago (2015-02-05 08:34:57 UTC) #3
Michael Starzinger
LGTM (rubber-stamped).
5 years, 10 months ago (2015-02-05 08:57:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/900123003/20001
5 years, 10 months ago (2015-02-05 09:19:38 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-05 09:40:25 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 09:40:38 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a559367956d870de38375a51e919a2c06c004e26
Cr-Commit-Position: refs/heads/master@{#26451}

Powered by Google App Engine
This is Rietveld 408576698