Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 900103002: Fix random lint warnings in chrome/android/shell (Closed)

Created:
5 years, 10 months ago by aurimas (slooooooooow)
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix random lint warnings in chrome/android/shell BUG=266140 Committed: https://crrev.com/eb640d0e9f1336efb6ca3d9773e9b65de99ec85a Cr-Commit-Position: refs/heads/master@{#314914}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M chrome/android/shell/res/layout/chrome_shell_activity.xml View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/android/shell/res/layout/suggestion_item.xml View 4 chunks +5 lines, -2 lines 0 comments Download
M chrome/android/shell/res/menu/main_menu.xml View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
aurimas (slooooooooow)
dtrainor: PTAL
5 years, 10 months ago (2015-02-05 01:26:54 UTC) #2
David Trainor- moved to gerrit
thanks for fixing these! lgtm
5 years, 10 months ago (2015-02-05 23:01:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/900103002/1
5 years, 10 months ago (2015-02-05 23:08:56 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-05 23:32:48 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 23:33:50 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eb640d0e9f1336efb6ca3d9773e9b65de99ec85a
Cr-Commit-Position: refs/heads/master@{#314914}

Powered by Google App Engine
This is Rietveld 408576698