Fix for alphanumerics following braces.

lib/src/rules/unnecessary_brace_in_string_interp.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library unnecessary_brace_in_string_interp;
 
 import 'package:analyzer/src/generated/ast.dart';
 import 'package:analyzer/src/generated/error.dart';
+import 'package:analyzer/src/generated/scanner.dart';
 import 'package:analyzer/src/services/lint.dart';
 
+final RegExp alphaNumeric = new RegExp(r'^[a-zA-Z0-9]');
+
 const msg = '''
 Interpolated simple identifiers (not followed by an alphanumeric string) do
 not need braces.

[Brian Wilkerson, 2015/02/05 01:38:42]

Don't include end-of-line characters in the message. Clients are responsible for
wrapping messages where necessary.

[pquitslund, 2015/02/05 03:42:06]

Done.

 ''';
 
 const name = 'UnnecessaryBraceInStringInterp';
 
+bool isAlphaNumeric(Token token) =>
+    token is StringToken && token.lexeme.startsWith(alphaNumeric);
+
 class UnnecessaryBraceInStringInterp extends Linter {
   @override
   AstVisitor getVisitor() => new Visitor(reporter);
 }
 
 class Visitor extends SimpleAstVisitor<Object> {

[scheglov, 2015/02/05 01:38:08]

Remove <Object>.

[pquitslund, 2015/02/05 03:42:06]

Done.

   ErrorReporter reporter;
   Visitor(this.reporter);
 
   @override
   visitStringInterpolation(StringInterpolation node) {
     var expressions = node.elements.where((e) => e is InterpolationExpression);
     for (InterpolationExpression expression in expressions) {
-      if (expression.expression is SimpleIdentifier &&
-          expression.rightBracket != null) {
-        reporter.reportErrorForNode(new LintCode(name, msg), expression, []);
+      if (expression.expression is SimpleIdentifier) {
+        Token bracket = expression.rightBracket;
+        if (bracket != null && !isAlphaNumeric(bracket.next)) {
+          reporter.reportErrorForNode(new LintCode(name, msg), expression, []);

[Brian Wilkerson, 2015/02/05 01:38:42]

I would recommend defining static constant fields in LintCode. I think it makes
it easier to find where messages are being produced when all you're given in a
bug report is the message that was displayed.

[pquitslund, 2015/02/05 03:42:06]

Agreed!  That said, if I understand you right, I'm not completely sure how that
would work since LintCode is defined in the analyzer package and the lints are
contributed outside it...

+        }
       }
     }
   }
 }