Refactor of manifest files to be more consistent and organized.

Refactor of manifest files to be more consistent.

Committed: https://crrev.com/641b819734a207804291e77bd415bc599b393900
Cr-Commit-Position: refs/heads/master@{#316613}

[Peter Wen, 2015-02-05 14:15:21]

wnwen@chromium.org changed reviewers:
+ shuchen@chromium.org, wuyingbing@chromium.org

[Peter Wen, 2015-02-05 14:15:21]

Run manifest_organizer.py on all input_method manifests.

[Shu Chen, 2015-02-05 15:34:18]

lgtm

[Peter Wen, 2015-02-05 19:42:08]

New patchsets have been uploaded after l-g-t-m from shuchen@chromium.org

[Peter Wen, 2015-02-05 19:44:15]

wnwen@chromium.org changed reviewers:
+ nkostylev@chromium.org

[Peter Wen, 2015-02-05 19:44:15]

+nkostylev for OWNERS: //chrome/browser/chromeos/login

[Peter Wen, 2015-02-09 15:36:07]

Friendly ping for OWNERS approval. :)

[Nikita (slow), 2015-02-11 14:18:53]

nkostylev@chromium.org changed reviewers:
+ alemate@chromium.org

[Nikita (slow), 2015-02-11 14:18:53]

+alemate@

Looking at the test, does this mean that new order would be like one below?

"xkb:us::eng"
"xkb:us:altgr-intl:eng"
"xkb:us:colemak:eng"
"xkb:us:dvorak:eng"
"xkb:us:intl:eng"

I think "xkb:us:intl:eng" was second for a reason.

[Peter Wen, 2015-02-11 14:40:17]

On 2015/02/11 14:18:53, Nikita wrote:
> +alemate@
> 
> Looking at the test, does this mean that new order would be like one below?
> 
> "xkb:us::eng"
> "xkb:us:altgr-intl:eng"
> "xkb:us:colemak:eng"
> "xkb:us:dvorak:eng"
> "xkb:us:intl:eng"
> 
> I think "xkb:us:intl:eng" was second for a reason.

Correct, it now sorts by ID alphabetically.

If there's a UX reason for the previous ordering, I'd be happy to change the
sorting/grouping algorithm to accommodate.

[Shu Chen, 2015-02-12 01:04:39]

NOT lgtm.

Sorry I was too rushing for the l-g-t-m.

Changing input methods orders are too risky and WILL cause regressions.

I would recommend that in this cl we just beautify the manifest but keep the
order.

And Peter and I will discuss offline to well organize the manifest without
messing up the orders.

Thanks

[Nikita (slow), 2015-02-12 11:30:02]

On 2015/02/11 14:40:17, Peter Wen wrote:
> On 2015/02/11 14:18:53, Nikita wrote:
> > +alemate@
> > 
> > Looking at the test, does this mean that new order would be like one below?
> > 
> > "xkb:us::eng"
> > "xkb:us:altgr-intl:eng"
> > "xkb:us:colemak:eng"
> > "xkb:us:dvorak:eng"
> > "xkb:us:intl:eng"
> > 
> > I think "xkb:us:intl:eng" was second for a reason.
> 
> Correct, it now sorts by ID alphabetically.
> 
> If there's a UX reason for the previous ordering, I'd be happy to change the
> sorting/grouping algorithm to accommodate.

Exactly, there was a UX reason behind that like xkb:us:intl:eng being more
popular layout than others.

[Peter Wen, 2015-02-12 14:07:02]

Thanks for catching this and explaining, Nikita. I did not realize at the time
that the ordering in the manifest file was the ordering in the UI. :)

PTAL. Now only formatting changes.

[Shu Chen, 2015-02-15 07:31:06]

lgtm

[Nikita (slow), 2015-02-16 11:17:10]

lgtm

[Alexander Alekseev, 2015-02-16 14:31:56]

alemate@chromium.org changed reviewers:
- alemate@chromium.org

[Peter Wen, 2015-02-17 18:29:56]

The CQ bit was checked by wnwen@chromium.org

[commit-bot: I haz the power, 2015-02-17 18:30:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/900053003/40001

[commit-bot: I haz the power, 2015-02-17 18:37:34]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-02-17 18:38:16]

Patchset 3 (id:??) landed as
https://crrev.com/641b819734a207804291e77bd415bc599b393900
Cr-Commit-Position: refs/heads/master@{#316613}