Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 900033003: split interceptor tests off of test-api (Closed)

Created:
5 years, 10 months ago by dcarney
Modified:
5 years, 10 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4003 lines, -4042 lines) Patch
M test/cctest/cctest.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M test/cctest/cctest.status View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A test/cctest/test-api.h View 1 chunk +34 lines, -0 lines 0 comments Download
M test/cctest/test-api.cc View 1 122 chunks +1057 lines, -4042 lines 0 comments Download
A test/cctest/test-api-interceptors.cc View 1 chunk +2909 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Toon Verwaest
lgtm
5 years, 10 months ago (2015-02-06 11:23:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/900033003/20001
5 years, 10 months ago (2015-02-06 11:32:13 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/2645)
5 years, 10 months ago (2015-02-06 12:00:55 UTC) #7
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/878963a8a5f0a643ea9601177f68d1fc675dc55f Cr-Commit-Position: refs/heads/master@{#26484}
5 years, 10 months ago (2015-02-06 12:08:17 UTC) #8
dcarney
5 years, 10 months ago (2015-02-06 12:08:26 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
878963a8a5f0a643ea9601177f68d1fc675dc55f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698