Issue 899993002: Add a thread-safe CreateChannel method to ChannelManager.

Issue 899993002: Add a thread-safe CreateChannel method to ChannelManager. (Closed)

Created:
5 years, 10 months ago by viettrungluu

Modified:
5 years, 10 months ago

Reviewers:
yzshen1

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Add a thread-safe CreateChannel method to ChannelManager. R=yzshen@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/739a4b7ce9dec4c247533665c0a538dbc1e65280

Patch Set 1 #

Total comments: 1

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+77 lines, -29 lines)			Patch
M	mojo/edk/embedder/embedder.cc	View	2 chunks	+6 lines, -25 lines	0 comments	Download
M	mojo/edk/embedder/embedder_unittest.cc	View	2 chunks	+6 lines, -2 lines	0 comments	Download
M	mojo/edk/system/channel_manager.h	View	3 chunks	+30 lines, -2 lines	1 comment	Download
M	mojo/edk/system/channel_manager.cc	View	3 chunks	+35 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

yzshen1

lgtm https://codereview.chromium.org/899993002/diff/1/mojo/edk/system/channel_manager.h File mojo/edk/system/channel_manager.h (right): https://codereview.chromium.org/899993002/diff/1/mojo/edk/system/channel_manager.h#newcode61 mojo/edk/system/channel_manager.h:61: // |callback_thread_task_runner| is null else by posting to ...

5 years, 10 months ago (2015-02-04 21:21:06 UTC) #2

viettrungluu

Thanks. On 2015/02/04 21:21:06, yzshen1 wrote: > lgtm > > https://codereview.chromium.org/899993002/diff/1/mojo/edk/system/channel_manager.h > File mojo/edk/system/channel_manager.h (right): ...

5 years, 10 months ago (2015-02-04 21:24:30 UTC) #3

viettrungluu

5 years, 10 months ago (2015-02-04 21:25:30 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
739a4b7ce9dec4c247533665c0a538dbc1e65280 (presubmit successful).

Expand Messages | Collapse Messages