Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 899983002: Revert of Introduce HostID and de-couple Extensions from "script injection System" [browser side] (Closed)

Created:
5 years, 10 months ago by Xi Han
Modified:
5 years, 10 months ago
Reviewers:
Fady Samuel, Devlin
CC:
chromium-reviews, darin-cc_chromium.org, jam, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Introduce HostID and de-couple Extensions from "script injection System" [browser side] (patchset #20 id:760001 of https://codereview.chromium.org/822453002/) Reason for revert: It might cause the crash https://code.google.com/p/chromium/issues/detail?id=454917. Original issue's description: > Introduce HostID and de-couple Extensions from "script injection System" [browser side] > > The major refactor includes: > - Introduce HostID (a pair of |id, type|) to replace extension_id in browser > side. > - Abstract UserScriptLoader to be a base class, and introduces > a derived class ExtensionUserScriptLoader which is > responsible for loading user scripts for extensions. > - In DeclarativeUserScriptManager, a master is created per > extension/webUI. > - DeclarativeUserScriptManager becomes an > ExtensionRegistryObserver and is responsible for clearing scripts > for master objects when receive OnExensionUnloaded event. > > BUG=437566 > > Committed: https://crrev.com/b88fe3dc1072501bdd105fd95a8b3bc453fd2aa7 > Cr-Commit-Position: refs/heads/master@{#313402} TBR=fsamuel@chromium.org,rdevlin.cronin@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=437566 Committed: https://crrev.com/5eb894ea21637241e9a78fb9c2737d40d6dbf575 Cr-Commit-Position: refs/heads/master@{#314631}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+379 lines, -932 lines) Patch
M chrome/browser/extensions/api/declarative_content/chrome_content_rules_registry.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/declarative_content/content_action.h View 1 4 chunks +1 line, -11 lines 0 comments Download
M chrome/browser/extensions/api/declarative_content/content_action.cc View 1 12 chunks +6 lines, -18 lines 0 comments Download
M chrome/browser/extensions/api/declarative_content/content_action_unittest.cc View 1 14 chunks +3 lines, -15 lines 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_action_unittest.cc View 1 5 chunks +8 lines, -15 lines 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/extensions/convert_user_script.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/declarative_user_script_manager.h View 1 2 chunks +9 lines, -24 lines 0 comments Download
M chrome/browser/extensions/declarative_user_script_manager.cc View 1 2 chunks +6 lines, -27 lines 0 comments Download
M chrome/browser/extensions/declarative_user_script_master.h View 1 2 chunks +20 lines, -8 lines 0 comments Download
M chrome/browser/extensions/declarative_user_script_master.cc View 1 1 chunk +17 lines, -5 lines 0 comments Download
D chrome/browser/extensions/extension_user_script_loader.h View 1 1 chunk +0 lines, -59 lines 0 comments Download
D chrome/browser/extensions/extension_user_script_loader.cc View 1 1 chunk +0 lines, -166 lines 0 comments Download
D chrome/browser/extensions/extension_user_script_loader_unittest.cc View 1 1 chunk +0 lines, -276 lines 0 comments Download
M chrome/browser/extensions/shared_user_script_master.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/shared_user_script_master.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/user_script_loader.h View 1 8 chunks +46 lines, -59 lines 0 comments Download
M chrome/browser/extensions/user_script_loader.cc View 1 10 chunks +195 lines, -83 lines 0 comments Download
A + chrome/browser/extensions/user_script_loader_unittest.cc View 1 16 chunks +30 lines, -42 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/common/extensions/manifest_handlers/content_scripts_handler.cc View 1 2 chunks +1 line, -2 lines 0 comments Download
M extensions/browser/api/declarative/declarative_rule.h View 1 7 chunks +3 lines, -9 lines 0 comments Download
M extensions/browser/api/declarative/declarative_rule_unittest.cc View 1 7 chunks +17 lines, -24 lines 0 comments Download
M extensions/browser/api/declarative_webrequest/webrequest_action.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/api/declarative_webrequest/webrequest_action.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/api/declarative_webrequest/webrequest_rules_registry.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M extensions/common/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
D extensions/common/host_id.h View 1 1 chunk +0 lines, -39 lines 0 comments Download
M extensions/common/user_script.h View 1 6 chunks +6 lines, -13 lines 0 comments Download
M extensions/common/user_script.cc View 1 4 chunks +2 lines, -17 lines 0 comments Download
M extensions/common/user_script_unittest.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M extensions/extensions.gyp View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
Xi Han
Created Revert of Introduce HostID and de-couple Extensions from "script injection System" [browser side]
5 years, 10 months ago (2015-02-04 20:41:25 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/899983002/1
5 years, 10 months ago (2015-02-04 20:42:30 UTC) #2
commit-bot: I haz the power
Failed to apply patch for extensions/common/BUILD.gn: While running git apply --index -3 -p1; error: patch ...
5 years, 10 months ago (2015-02-04 20:43:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/899983002/270001
5 years, 10 months ago (2015-02-04 21:04:40 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:270001)
5 years, 10 months ago (2015-02-04 21:06:08 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/5eb894ea21637241e9a78fb9c2737d40d6dbf575 Cr-Commit-Position: refs/heads/master@{#314631}
5 years, 10 months ago (2015-02-04 21:07:12 UTC) #9
Xi Han
5 years, 10 months ago (2015-02-05 14:22:03 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:270001) has been created in
https://codereview.chromium.org/903743002/ by hanxi@chromium.org.

The reason for reverting is: It turns out that the crash wasn't caused by this
CL..

Powered by Google App Engine
This is Rietveld 408576698