|
|
Created:
5 years, 10 months ago by Alexander Potapenko Modified:
5 years, 10 months ago Reviewers:
earthdok CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionEnable sanitizer default options for 32-bit CrOS
BUG=302040
TBR=earthdok@chromium.org
Committed: https://crrev.com/0ed000a79da1b02a8a3d095286f3e076d732f393
Cr-Commit-Position: refs/heads/master@{#315291}
Patch Set 1 #
Messages
Total messages: 16 (6 generated)
glider@chromium.org changed reviewers: + earthdok@chromium.org
TBR. Let us see if anything changed since my last attempt. IIRC there've been changes on v8 side that could've fixed the problems with 32-bit builds.
The CQ bit was checked by glider@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/899973006/1
The CQ bit was unchecked by commit-bot@chromium.org
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an LGTM may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
The CQ bit was checked by glider@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/899973006/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) ios_rel_device_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) ios_rel_device_ninja_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) Timed out jobs are not retried to avoid causing additional load on the builders with large pending queues.
The CQ bit was checked by glider@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/899973006/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/0ed000a79da1b02a8a3d095286f3e076d732f393 Cr-Commit-Position: refs/heads/master@{#315291}
Message was sent while issue was closed.
lgtm
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/912123002/ by girard@chromium.org. The reason for reverting is: x86-ASAN is breaking: see http://build.chromium.org/p/chromiumos/builders/x86-generic%20ASAN/builds/203... chromeos-chrome-42.0.2301.0_rc-r1: FAILED: clang++ -Wl,-O2 -Wl,--as-needed -Wl,-z,now -Wl,-z,relro -Wl,--fatal-warnings -pthread -Wl,-z,noexecstack -fPIC -fuse-ld=gold -Wl,-u_sanitizer_options_link_helper -m32 -Wl,-O1 -Wl,--gc-sections -o mksnapshot -Wl,--start-group obj.host/v8/src/mksnapshot.mksnapshot.o obj.host/build/sanitizers/libsanitizer_options.a obj.host/v8/tools/gyp/libv8_base.a obj.host/v8/tools/gyp/libv8_nosnapshot.a obj.host/v8/tools/gyp/libv8_libplatform.a obj.host/third_party/icu/libicui18n.a obj.host/third_party/icu/libicuuc.a obj.host/v8/tools/gyp/libv8_libbase.a obj.host/third_party/icu/libicudata.a -Wl,--end-group -lrt chromeos-chrome-42.0.2301.0_rc-r1: /usr/x86_64-pc-linux-gnu/binutils-bin/2.24/ld.gold.real: error: obj.host/build/sanitizers/libsanitizer_options.a(obj.host/build/sanitizers/sanitizer_options.sanitizer_options.o): incompatible target . |