Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 899973006: Enable sanitizer default options for 32-bit CrOS (Closed)

Created:
5 years, 10 months ago by Alexander Potapenko
Modified:
5 years, 10 months ago
Reviewers:
earthdok
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable sanitizer default options for 32-bit CrOS BUG=302040 TBR=earthdok@chromium.org Committed: https://crrev.com/0ed000a79da1b02a8a3d095286f3e076d732f393 Cr-Commit-Position: refs/heads/master@{#315291}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/common.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (6 generated)
Alexander Potapenko
TBR. Let us see if anything changed since my last attempt. IIRC there've been changes ...
5 years, 10 months ago (2015-02-09 10:07:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/899973006/1
5 years, 10 months ago (2015-02-09 10:08:31 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 10 months ago (2015-02-09 10:08:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/899973006/1
5 years, 10 months ago (2015-02-09 10:10:24 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) ios_rel_device_ng on ...
5 years, 10 months ago (2015-02-09 12:11:48 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/899973006/1
5 years, 10 months ago (2015-02-09 12:15:25 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-09 13:54:28 UTC) #13
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0ed000a79da1b02a8a3d095286f3e076d732f393 Cr-Commit-Position: refs/heads/master@{#315291}
5 years, 10 months ago (2015-02-09 13:54:50 UTC) #14
earthdok
lgtm
5 years, 10 months ago (2015-02-09 14:17:56 UTC) #15
girard
5 years, 10 months ago (2015-02-10 23:00:45 UTC) #16
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/912123002/ by girard@chromium.org.

The reason for reverting is: x86-ASAN is breaking: see
http://build.chromium.org/p/chromiumos/builders/x86-generic%20ASAN/builds/203...

chromeos-chrome-42.0.2301.0_rc-r1: FAILED: clang++ -Wl,-O2 -Wl,--as-needed
-Wl,-z,now -Wl,-z,relro -Wl,--fatal-warnings -pthread -Wl,-z,noexecstack -fPIC
-fuse-ld=gold -Wl,-u_sanitizer_options_link_helper -m32 -Wl,-O1
-Wl,--gc-sections -o mksnapshot -Wl,--start-group
obj.host/v8/src/mksnapshot.mksnapshot.o
obj.host/build/sanitizers/libsanitizer_options.a
obj.host/v8/tools/gyp/libv8_base.a obj.host/v8/tools/gyp/libv8_nosnapshot.a
obj.host/v8/tools/gyp/libv8_libplatform.a obj.host/third_party/icu/libicui18n.a
obj.host/third_party/icu/libicuuc.a obj.host/v8/tools/gyp/libv8_libbase.a
obj.host/third_party/icu/libicudata.a -Wl,--end-group  -lrt
chromeos-chrome-42.0.2301.0_rc-r1:
/usr/x86_64-pc-linux-gnu/binutils-bin/2.24/ld.gold.real: error:
obj.host/build/sanitizers/libsanitizer_options.a(obj.host/build/sanitizers/sanitizer_options.sanitizer_options.o):
incompatible target
.

Powered by Google App Engine
This is Rietveld 408576698