Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Issue 899973002: Revert of Device Orientation API on Chrome OS (Closed)

Created:
5 years, 10 months ago by jonross
Modified:
5 years, 10 months ago
Reviewers:
jam, timvolodine
CC:
chromium-reviews, riju_, Michael van Ouwerkerk, jam, timvolodine, darin-cc_chromium.org, mlamouri+watch-sensors_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Device Orientation API on Chrome OS (patchset #8 id:200001 of https://codereview.chromium.org/856123002/) Reason for revert: Compilation failure on CQ: http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20Linux%20ChromeOS%20MSan%20Builder/builds/1666/steps/compile/logs/stdio Original issue's description: > Device Orientation API on Chrome OS > > Implement DataFetcherSharedMemory on Chrome OS to provide Device Orientation support. Create SensorManagerChromeOS to observe accelerometer events, and to generate updates to the Device Orientation API. > > This is a follow up to: https://codereview.chromium.org/680383007/ > > With the accelerometer on Chrome OS now exposed to content/ from chromeos/accelerometer, no ash/ implementation is required. No public api in content/public/browser is needed either. > > TEST=SensorManagerTest.OrientationBuffer, SensorManagerTest.NeutralOrientation, SensorManagerTest.UpsideDown, SensorManagerTest.BeforeUpsideDownBoundary, SensorManagerTest.LeftEdge, SensorManagerTest.RightEdge, SensorManagerTest.BeforeRightEdgeBoundary > BUG=342908 > > Committed: https://crrev.com/e717460964dd27a7239abec31462441eb971edbe > Cr-Commit-Position: refs/heads/master@{#314605} TBR=timvolodine@chromium.org,jam@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=342908 Committed: https://crrev.com/cc6a8bfeb49e93068e8df28f406e6ad0b5d6915e Cr-Commit-Position: refs/heads/master@{#314622}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -391 lines) Patch
M content/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/device_sensors/data_fetcher_shared_memory.h View 2 chunks +2 lines, -7 lines 0 comments Download
D content/browser/device_sensors/data_fetcher_shared_memory_chromeos.cc View 1 chunk +0 lines, -53 lines 0 comments Download
D content/browser/device_sensors/sensor_manager_chromeos.h View 1 chunk +0 lines, -55 lines 0 comments Download
D content/browser/device_sensors/sensor_manager_chromeos.cc View 1 chunk +0 lines, -119 lines 0 comments Download
D content/browser/device_sensors/sensor_manager_chromeos_unittest.cc View 1 chunk +0 lines, -151 lines 0 comments Download
M content/content_browser.gypi View 3 chunks +0 lines, -4 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
jonross
Created Revert of Device Orientation API on Chrome OS
5 years, 10 months ago (2015-02-04 20:25:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/899973002/1
5 years, 10 months ago (2015-02-04 20:26:08 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-04 20:27:21 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 20:28:46 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cc6a8bfeb49e93068e8df28f406e6ad0b5d6915e
Cr-Commit-Position: refs/heads/master@{#314622}

Powered by Google App Engine
This is Rietveld 408576698