Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 899933002: IndexedDB: Re-enable leveldb manifest reuse. (Closed)

Created:
5 years, 10 months ago by cmumford
Modified:
5 years, 10 months ago
Reviewers:
michaeln, dgrogan
CC:
chromium-reviews, darin-cc_chromium.org, dgrogan, jsbell+idb_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

IndexedDB: Re-enable leveldb manifest reuse. The new leveldb manifest reuse feature was disabled because the CrOS dev channel daily error % by channel values increased after this landed in that channel (by about 3x). Reverting this change did not return the dev channel rates back to normal. Furthermore the beta channel (with this feature enabled) did not experience an increase in errors. Commit details: Returns manifest reuse back to the state introduced in crrev.com/803603004 (de701ab) which was disabled in two subsequent reverts: crrev.com/841753003 (ca6c875) and crrev.com/852073002 (617e94e). BUG=402980 Committed: https://crrev.com/6bd2fc1919a84eff0141634ccc49483669ab7e37 Cr-Commit-Position: refs/heads/master@{#314638}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -1 line) Patch
M content/browser/indexed_db/leveldb/leveldb_database.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/leveldatabase/env_chromium.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/leveldatabase/env_chromium.cc View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
cmumford
5 years, 10 months ago (2015-02-04 18:46:42 UTC) #2
dgrogan
Is the plan still to fully enable on the 41 beta branch instead of its ...
5 years, 10 months ago (2015-02-04 19:21:07 UTC) #3
cmumford
On 2015/02/04 19:21:07, dgrogan wrote: > Is the plan still to fully enable on the ...
5 years, 10 months ago (2015-02-04 19:31:02 UTC) #4
dgrogan
lgtm
5 years, 10 months ago (2015-02-04 20:01:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/899933002/1
5 years, 10 months ago (2015-02-04 20:15:02 UTC) #7
michaeln
lgtm 2, great to see this going back in!
5 years, 10 months ago (2015-02-04 20:15:43 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-04 21:24:20 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 21:25:26 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6bd2fc1919a84eff0141634ccc49483669ab7e37
Cr-Commit-Position: refs/heads/master@{#314638}

Powered by Google App Engine
This is Rietveld 408576698