Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Unified Diff: Source/bindings/v8/ScriptEventListener.cpp

Issue 89993002: Pass AtomicStrings as 2 first arguments to V8LazyEventListener::create() (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/v8/ScriptEventListener.cpp
diff --git a/Source/bindings/v8/ScriptEventListener.cpp b/Source/bindings/v8/ScriptEventListener.cpp
index 25751650b3b521deea02e4d6dbfb7dffec078c1c..c1b8ff438e22d87314591aed23d0fc4c4f757ff2 100644
--- a/Source/bindings/v8/ScriptEventListener.cpp
+++ b/Source/bindings/v8/ScriptEventListener.cpp
@@ -44,10 +44,10 @@
namespace WebCore {
-static const String& eventParameterName(bool isSVGEvent)
+static const AtomicString& eventParameterName(bool isSVGEvent)
{
- DEFINE_STATIC_LOCAL(const String, eventString, ("event"));
- DEFINE_STATIC_LOCAL(const String, evtString, ("evt"));
+ DEFINE_STATIC_LOCAL(const AtomicString, eventString, ("event"));
+ DEFINE_STATIC_LOCAL(const AtomicString, evtString, ("evt"));
return isSVGEvent ? evtString : eventString;
}
@@ -73,7 +73,7 @@ PassRefPtr<V8LazyEventListener> createAttributeEventListener(Node* node, const Q
isolate = v8::Isolate::GetCurrent();
}
- return V8LazyEventListener::create(name.localName().string(), eventParameterName(node->isSVGElement()), value, sourceURL, position, node, isolate);
+ return V8LazyEventListener::create(name.localName(), eventParameterName(node->isSVGElement()), value, sourceURL, position, node, isolate);
}
PassRefPtr<V8LazyEventListener> createAttributeEventListener(Frame* frame, const QualifiedName& name, const AtomicString& value)
@@ -91,7 +91,7 @@ PassRefPtr<V8LazyEventListener> createAttributeEventListener(Frame* frame, const
TextPosition position = scriptController.eventHandlerPosition();
String sourceURL = frame->document()->url().string();
- return V8LazyEventListener::create(name.localName().string(), eventParameterName(frame->document()->isSVGDocument()), value, sourceURL, position, 0, toIsolate(frame));
+ return V8LazyEventListener::create(name.localName(), eventParameterName(frame->document()->isSVGDocument()), value, sourceURL, position, 0, toIsolate(frame));
}
String eventListenerHandlerBody(Document* document, EventListener* listener)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698