Issue 89993002: Pass AtomicStrings as 2 first arguments to V8LazyEventListener::create()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 89993002: Pass AtomicStrings as 2 first arguments to V8LazyEventListener::create() (Closed)

Created:
7 years ago by Inactive

Modified:
7 years ago

Reviewers:
haraken, abarth-chromium, eseidel

CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, Inactive

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Pass AtomicStrings as 2 first arguments to V8LazyEventListener::create() Pass AtomicStrings as 2 first arguments to V8LazyEventListener::create() in ScriptEventListener as this is what this factory method expects. This avoids uselessly constructing Strings and then converting them to AtomicStrings. R=abarth BUG=323739 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162718

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -5 lines)			Patch
	M	Source/bindings/v8/ScriptEventListener.cpp	View		3 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/89993002/1

7 years ago (2013-11-27 00:49:02 UTC) #3

Message was sent while issue was closed.

Change committed as 162718

Expand Messages | Collapse Messages