Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: ash/system/chromeos/session/logout_confirmation_controller_unittest.cc

Issue 899863002: Add support in TestMockTimeTaskRunner for vending out mock Time and mock Clocks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Start ticks from 0, some tests depend on this. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/test/test_mock_time_task_runner.h » ('j') | base/test/test_mock_time_task_runner.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/system/chromeos/session/logout_confirmation_controller_unittest.cc
diff --git a/ash/system/chromeos/session/logout_confirmation_controller_unittest.cc b/ash/system/chromeos/session/logout_confirmation_controller_unittest.cc
index fa30c9fd05c7ad457e00096280b01efe2854a7f3..cd0a4b4eaefbfbdfdea295c7acbb7b62c7f67557 100644
--- a/ash/system/chromeos/session/logout_confirmation_controller_unittest.cc
+++ b/ash/system/chromeos/session/logout_confirmation_controller_unittest.cc
@@ -9,6 +9,7 @@
#include "base/memory/ref_counted.h"
#include "base/test/test_mock_time_task_runner.h"
#include "base/thread_task_runner_handle.h"
+#include "base/time/tick_clock.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace ash {
@@ -50,7 +51,7 @@ void LogoutConfirmationControllerTest::LogOut() {
// Verifies that the user is logged out immediately if logout confirmation with
// a zero-length countdown is requested.
TEST_F(LogoutConfirmationControllerTest, ZeroDuration) {
- controller_.ConfirmLogout(runner_->GetCurrentMockTime());
+ controller_.ConfirmLogout(runner_->NowTicks());
EXPECT_FALSE(log_out_called_);
runner_->FastForwardBy(base::TimeDelta());
EXPECT_TRUE(log_out_called_);
@@ -58,8 +59,8 @@ TEST_F(LogoutConfirmationControllerTest, ZeroDuration) {
// Verifies that the user is logged out when the countdown expires.
TEST_F(LogoutConfirmationControllerTest, DurationExpired) {
- controller_.ConfirmLogout(
- runner_->GetCurrentMockTime() + base::TimeDelta::FromSeconds(10));
+ controller_.ConfirmLogout(runner_->NowTicks() +
+ base::TimeDelta::FromSeconds(10));
EXPECT_FALSE(log_out_called_);
runner_->FastForwardBy(base::TimeDelta::FromSeconds(9));
EXPECT_FALSE(log_out_called_);
@@ -71,13 +72,13 @@ TEST_F(LogoutConfirmationControllerTest, DurationExpired) {
// request's countdown ends before the original request's, the user is logged
// out when the new countdown expires.
TEST_F(LogoutConfirmationControllerTest, DurationShortened) {
- controller_.ConfirmLogout(
- runner_->GetCurrentMockTime() + base::TimeDelta::FromSeconds(30));
+ controller_.ConfirmLogout(runner_->NowTicks() +
+ base::TimeDelta::FromSeconds(30));
EXPECT_FALSE(log_out_called_);
runner_->FastForwardBy(base::TimeDelta::FromSeconds(9));
EXPECT_FALSE(log_out_called_);
- controller_.ConfirmLogout(
- runner_->GetCurrentMockTime() + base::TimeDelta::FromSeconds(10));
+ controller_.ConfirmLogout(runner_->NowTicks() +
+ base::TimeDelta::FromSeconds(10));
runner_->FastForwardBy(base::TimeDelta::FromSeconds(9));
EXPECT_FALSE(log_out_called_);
runner_->FastForwardBy(base::TimeDelta::FromSeconds(2));
@@ -88,13 +89,13 @@ TEST_F(LogoutConfirmationControllerTest, DurationShortened) {
// request's countdown ends after the original request's, the user is logged
// out when the original countdown expires.
TEST_F(LogoutConfirmationControllerTest, DurationExtended) {
- controller_.ConfirmLogout(
- runner_->GetCurrentMockTime() + base::TimeDelta::FromSeconds(10));
+ controller_.ConfirmLogout(runner_->NowTicks() +
+ base::TimeDelta::FromSeconds(10));
EXPECT_FALSE(log_out_called_);
runner_->FastForwardBy(base::TimeDelta::FromSeconds(9));
EXPECT_FALSE(log_out_called_);
- controller_.ConfirmLogout(
- runner_->GetCurrentMockTime() + base::TimeDelta::FromSeconds(10));
+ controller_.ConfirmLogout(runner_->NowTicks() +
+ base::TimeDelta::FromSeconds(10));
runner_->FastForwardBy(base::TimeDelta::FromSeconds(2));
EXPECT_TRUE(log_out_called_);
}
@@ -102,8 +103,8 @@ TEST_F(LogoutConfirmationControllerTest, DurationExtended) {
// Verifies that when the screen is locked while the countdown is running, the
// user is not logged out, even when the original countdown expires.
TEST_F(LogoutConfirmationControllerTest, Lock) {
- controller_.ConfirmLogout(
- runner_->GetCurrentMockTime() + base::TimeDelta::FromSeconds(10));
+ controller_.ConfirmLogout(runner_->NowTicks() +
+ base::TimeDelta::FromSeconds(10));
EXPECT_FALSE(log_out_called_);
controller_.OnLockStateChanged(true);
runner_->FastForwardUntilNoTasksRemain();
@@ -113,8 +114,8 @@ TEST_F(LogoutConfirmationControllerTest, Lock) {
// Verifies that when the user confirms the logout request, the user is logged
// out immediately.
TEST_F(LogoutConfirmationControllerTest, UserAccepted) {
- controller_.ConfirmLogout(
- runner_->GetCurrentMockTime() + base::TimeDelta::FromSeconds(10));
+ controller_.ConfirmLogout(runner_->NowTicks() +
+ base::TimeDelta::FromSeconds(10));
EXPECT_FALSE(log_out_called_);
controller_.OnLogoutConfirmed();
EXPECT_TRUE(log_out_called_);
@@ -123,8 +124,8 @@ TEST_F(LogoutConfirmationControllerTest, UserAccepted) {
// Verifies that when the user denies the logout request, the user is not logged
// out, even when the original countdown expires.
TEST_F(LogoutConfirmationControllerTest, UserDenied) {
- controller_.ConfirmLogout(
- runner_->GetCurrentMockTime() + base::TimeDelta::FromSeconds(10));
+ controller_.ConfirmLogout(runner_->NowTicks() +
+ base::TimeDelta::FromSeconds(10));
EXPECT_FALSE(log_out_called_);
controller_.OnDialogClosed();
runner_->FastForwardUntilNoTasksRemain();
@@ -135,15 +136,15 @@ TEST_F(LogoutConfirmationControllerTest, UserDenied) {
// request is handled correctly and the user is logged out when the countdown
// expires.
TEST_F(LogoutConfirmationControllerTest, DurationExpiredAfterDeniedRequest) {
- controller_.ConfirmLogout(
- runner_->GetCurrentMockTime() + base::TimeDelta::FromSeconds(10));
+ controller_.ConfirmLogout(runner_->NowTicks() +
+ base::TimeDelta::FromSeconds(10));
EXPECT_FALSE(log_out_called_);
controller_.OnDialogClosed();
runner_->FastForwardUntilNoTasksRemain();
EXPECT_FALSE(log_out_called_);
- controller_.ConfirmLogout(
- runner_->GetCurrentMockTime() + base::TimeDelta::FromSeconds(10));
+ controller_.ConfirmLogout(runner_->NowTicks() +
+ base::TimeDelta::FromSeconds(10));
EXPECT_FALSE(log_out_called_);
runner_->FastForwardBy(base::TimeDelta::FromSeconds(9));
EXPECT_FALSE(log_out_called_);
« no previous file with comments | « no previous file | base/test/test_mock_time_task_runner.h » ('j') | base/test/test_mock_time_task_runner.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698