Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 899833003: Revert of Simplify WeakMap and WeakSet tests slightly. (Closed)

Created:
5 years, 10 months ago by yurys
Modified:
5 years, 10 months ago
CC:
v8-dev, yurys
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Simplify WeakMap and WeakSet tests slightly. (patchset #1 id:1 of https://codereview.chromium.org/903463002/) Reason for revert: Revert this patch as the original CL has to be reverted to due to shared win build failure http://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20nosnap%20-%20shared/builds/5030/steps/compile/logs/stdio Original issue's description: > Simplify WeakMap and WeakSet tests slightly. > > R=rossberg@chromium.org > TEST=cctest/test-weakmaps,cctest/test-weaksets > > Committed: https://crrev.com/a90d7a871da19d33e93c8779186408c8d1615cac > Cr-Commit-Position: refs/heads/master@{#26428} TBR=rossberg@chromium.org,mstarzinger@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/e225675ea605b7535292ea45c02f95ae7ae04480 Cr-Commit-Position: refs/heads/master@{#26429}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -15 lines) Patch
M test/cctest/test-weakmaps.cc View 5 chunks +13 lines, -8 lines 0 comments Download
M test/cctest/test-weaksets.cc View 5 chunks +14 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
yurys
Created Revert of Simplify WeakMap and WeakSet tests slightly.
5 years, 10 months ago (2015-02-04 15:10:36 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/899833003/1
5 years, 10 months ago (2015-02-04 15:11:22 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-04 15:11:34 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e225675ea605b7535292ea45c02f95ae7ae04480 Cr-Commit-Position: refs/heads/master@{#26429}
5 years, 10 months ago (2015-02-04 15:11:51 UTC) #4
Michael Starzinger
5 years, 10 months ago (2015-02-04 15:11:53 UTC) #5
Message was sent while issue was closed.
LGTM (rubber-stamped). Please integrate this CL in the re-land.

Powered by Google App Engine
This is Rietveld 408576698